-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document remote file staging #5523
Merged
bentsherman
merged 10 commits into
nextflow-io:master
from
christopher-hakkaart:docs-filedownload
Dec 19, 2024
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
9c2786c
Add details about file download as per #5493
christopher-hakkaart bfbe94e
Update docs
bentsherman 207f761
Remove extraneous sentence
bentsherman 3e01f0d
Suggest new language
christopher-hakkaart ea8db45
Update docs/working-with-files.md
christopher-hakkaart 622033d
Update docs/working-with-files.md
christopher-hakkaart a30e9d8
Update docs/working-with-files.md
christopher-hakkaart a943820
Update docs/working-with-files.md
christopher-hakkaart e82417f
Apply suggestions from review
bentsherman bac899e
Merge branch 'master' into docs-filedownload
bentsherman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to better this kind of file transfer happens every time the origin or the destination of the file system is different from the workflow work directory.
For example, the input file is in the local computer or it's a http remote file AND the pipeline uses S3 bucket as work dir, then nextflow needs to copy into S3. Same logic when it needs to copy the output files.
For the same reason it's important to advice to keep the input and outputs in the same storage system e.g. S3 or shared file system.
Minor: it would be preferable use "copy" or download input files and upload output files instead instead of "stage" that's too slang tech term.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still prefer to call it "remote file staging" in summary because it is concise. But I will explain it as copying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no problem with staging definition, however the part how improve the definition of "remote" file. A local file it's consider remote if the work dir is, for example, S3.