Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(job): Check if carddata is resource and read it to string #49332

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

wolandtel
Copy link
Contributor

Check if oc_cards.carddata has been read as resource and read it to string.

@solracsf solracsf added this to the Nextcloud 31 milestone Nov 16, 2024
@solracsf solracsf added 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels Nov 16, 2024
@solracsf solracsf changed the title Fix bug nextcloud/server#46100 fix(job): Check if carddata is resource and read it to string Nov 16, 2024
@ChristophWurst ChristophWurst requested review from st3iny and removed request for miaulalala November 18, 2024 07:56
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits into one, then we are ready for shipping :shipit:

@joshtrichards
Copy link
Member

/backport to stable30

@joshtrichards
Copy link
Member

/backport to stable29

@joshtrichards
Copy link
Member

/backport to stable28

@solracsf
Copy link
Member

Please squash your commits into one, then we are ready for shipping :shipit:

And commit as fix(job): Check if carddata is resource and read it to string :)

Fixes nextcloud#46100

Co-authored-by: Christoph Wurst <[email protected]>
Signed-off-by: Mikhail Kotelnikov <[email protected]>
@wolandtel
Copy link
Contributor Author

done

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 19, 2024
@skjnldsv skjnldsv merged commit 8f6ef39 into nextcloud:master Nov 19, 2024
173 of 176 checks passed
Copy link

welcome bot commented Nov 19, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

This comment was marked as resolved.

@skjnldsv
Copy link
Member

/backport to stable30

This comment was marked as resolved.

@solracsf
Copy link
Member

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: carddav Related to CardDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error while running background job OCA\\DAV\\Migration\\BuildSocialSearchIndexBackgroundJob
6 participants