Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Properly reset all file list filters on view change #49261

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(files): Properly reset all file list filters on view change #49261

wants to merge 2 commits into from
+144 −80

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 13, 2024

Summary

Ensure that by design all file list filters are reset on view change.
This is now implemented in the interface rather than manually listening to event by every filter.

Also refactored the filters store to store-setup style as this allows to run an init function.

Checklist

@susnux susnux added 3. to review Waiting for reviews feature: files labels Nov 13, 2024
@susnux susnux added this to the Nextcloud 31 milestone Nov 13, 2024
@susnux susnux requested review from a team, artonge, Pytal and szaimen and removed request for a team November 13, 2024 16:12
skjnldsv
skjnldsv approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense

@susnux
Copy link
Contributor Author

susnux commented Nov 18, 2024

/backport to stable30

@susnux
Copy link
Contributor Author

susnux commented Nov 19, 2024

/compile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@nfebe nfebe nfebe approved these changes

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request feature: files
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @nfebe @skjnldsv