add activity logging for favorites in dav

[grnd-alt]

• Resolves: Missing activity for favorites via WebDAV #26393

Summary

Dav api did not log favorite added/removed events.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

Would it not be cleaner and make more sense to emit just the event and handle the activity in an event listener?

Then only one place for the activity is required and one would not mix different apps (files app activity in dav app).

[artonge]

I don't get why this is need. Isn't TagService already doing that?

server/apps/files/lib/Service/TagService.php

Lines 101 to 131 in ff9ea47

	protected function addActivity($addToFavorite, $fileId, $path) {
	$user = $this->userSession->getUser();
	if (!$user instanceof IUser) {
	return;
	}
	if ($addToFavorite) {
	$event = new NodeAddedToFavorite($user, $fileId, $path);
	} else {
	$event = new NodeRemovedFromFavorite($user, $fileId, $path);
	}
	$this->dispatcher->dispatchTyped($event);
	$event = $this->activityManager->generateEvent();
	try {
	$event->setApp('files')
	->setObject('files', $fileId, $path)
	->setType('favorite')
	->setAuthor($user->getUID())
	->setAffectedUser($user->getUID())
	->setTimestamp(time())
	->setSubject(
	$addToFavorite ? FavoriteProvider::SUBJECT_ADDED : FavoriteProvider::SUBJECT_REMOVED,
	['id' => $fileId, 'path' => $path]
	);
	$this->activityManager->publish($event);
	} catch (\InvalidArgumentException $e) {
	} catch (\BadMethodCallException $e) {
	}
	}
	}

EDIT: reading the issue

[juliusknorr]

Wouldn't it make sense to dispatch the events in the tagAs and unTag methods in

server/lib/private/Tags.php

Line 505 in 77114fb

public function tagAs($objid, $tag) {

?

I cannot judge if there are cases where we don't want that, but if not we could save duplicate calls in https://github.com/nextcloud/server/pull/48612/files#diff-d2d90fa28b8b1a36f0664fa4a25a0753a765a824d0bd2524e7457d5be7a2d7a5R62 and potentially forgetting about code paths that should also store an activity entry.

[susnux]

I think we always want activities for tags, no?
So I agree with your comment :)

[juliusknorr]

Looks good, left one comment where I'm not familiar enough with the code paths to judge

[susnux]

Looks good!
Also Julius suggestion makes sense.