Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(users): improve recently active search #48559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(users): improve recently active search #48559

wants to merge 2 commits into from
+79 −22

Conversation

Altahrim
Copy link
Collaborator

@Altahrim Altahrim commented Oct 3, 2024 •
edited
Loading

Summary

  • Remove DISTINCT clause to fix PgSQL
  • Join user table only if necessary
  • Don't show people who never connected in active list
  • Add test

TODO

  • badge still count all users instead of actives ones

Checklist

@Altahrim
fix(users): improve recently active search
ec80e1b 
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test

Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim Altahrim self-assigned this Oct 3, 2024
@Altahrim Altahrim added bug 2. developing Work in progress labels Oct 3, 2024
@Altahrim
fix(users): use correct active user count
787de53 
Signed-off-by: Benjamin Gaussorgues <[email protected]>
@Altahrim
Copy link
Collaborator Author

Altahrim commented Oct 3, 2024

/backport to stable30

@Altahrim Altahrim requested review from a team, ArtificialOwl, artonge and come-nc and removed request for a team October 3, 2024 14:34
@Altahrim Altahrim marked this pull request as ready for review October 3, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc was automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees

@Altahrim Altahrim

Labels
2. developing Work in progress backport-request bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: accounts -> recently active does not work on pqsql
1 participant
@Altahrim