Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin_audit): Listen to the right events #48548

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 3, 2024

Summary

Fix issues from #44871 .
We cannot get the id before the write, because the file may not exist yet. On the contrary for delete we need to get it before deletion.
I remove the "update" listener since this hook has no equivalent in the events (and it is not really needed, it’s the same as NodeWrittenEvent, only difference is the update hook was only called for modifications and not for creations).

Checklist

@come-nc come-nc added the bug label Oct 3, 2024
@come-nc come-nc added this to the Nextcloud 31 milestone Oct 3, 2024
@come-nc come-nc self-assigned this Oct 3, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Oct 3, 2024

/backport to stable30

@come-nc come-nc requested review from a team, icewind1991 and Altahrim and removed request for a team October 3, 2024 09:05
@come-nc come-nc merged commit a9331e1 into master Oct 3, 2024
177 checks passed
@come-nc come-nc deleted the fix/fix-admin-audit-event-listening branch October 3, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error: admin_audit: NotFoundException Exception thrown in file write: Exception thrown in file write:
3 participants