-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not reduce count for subadmins if they are members of group #48532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
force-pushed
the
fix/48437/dont-exclude-user
branch
from
October 2, 2024 13:55
f460c33
to
583f015
Compare
provokateurin
requested changes
Oct 2, 2024
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
force-pushed
the
fix/48437/dont-exclude-user
branch
from
October 2, 2024 16:33
583f015
to
0d6acbf
Compare
provokateurin
approved these changes
Oct 2, 2024
blizzz
approved these changes
Oct 4, 2024
This was referenced Oct 4, 2024
This comment was marked as outdated.
This comment was marked as outdated.
/backport to stable30 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Counter on sidebar doesn't reflect the actual number of group members, if subadmin is a member too.
For each group, counter is reduced by 1, and for 'All accounts', counter is reduced by amount of groups subadmin is in.
There is a comment:
but I don't see a point of it, since we fetch and show yourself in the list anyway, so just removing inconsistency
TODO
Checklist