Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QueryBuilder): Account for aliases in output columns #48522

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Oct 2, 2024

Summary

#48361 added error logs when the output column is too long. #48521 shows the output columns weren't extracted correctly as it contained display_mode as display_mode_default which is actually fine because display_mode_default is only 20 chars.

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Oct 2, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Oct 2, 2024
@provokateurin provokateurin requested review from nickvergessen, a team, Altahrim, yemkareems and come-nc and removed request for a team October 2, 2024 09:57
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin provokateurin mentioned this pull request Oct 2, 2024
4 tasks
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, did not test.

Copy link
Member

@icewind1991 icewind1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should discourage apps from doing aliases like this instead of using selectAlias

@provokateurin provokateurin merged commit 8638a89 into master Oct 3, 2024
177 checks passed
@provokateurin provokateurin deleted the fix/querybuilder/output-columns-aliases branch October 3, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueryBuilder output columns incorrect
4 participants