feat: configurable request timeout for carddav sync #48418
Conversation
pabzm
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
pabzm
force-pushed
the
config-carddav-sync-request-timeout
branch
from
d3bd669
to
7b1d30c
Compare
… instead of magic number 30 Will be used to set default where we are able to override the default timeout. See #48418 Signed-off-by: Thomas Citharel <[email protected]>
… instead of magic number 30 Will be used to set default where we are able to override the default timeout. See #48418 Signed-off-by: Thomas Citharel <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
There was a problem hiding this comment.
1) OCA\DAV\Tests\unit\CardDAV\SyncServiceTest::testEmptySync
ArgumentCountError: Too few arguments to function OCA\DAV\CardDAV\SyncService::__construct(), 6 passed in /home/runner/work/server/server/apps/dav/tests/unit/CardDAV/SyncServiceTest.php on line 62 and exactly 7 expected
lmk if you need help with the tests
pabzm
force-pushed
the
config-carddav-sync-request-timeout
branch
2 times, most recently
from
de47a76
to
69a28ca
Compare
Big federated setups may need a longer timeout, which they now can configure. Signed-off-by: Pablo Zmdl <[email protected]> Co-authored-by: Josh <[email protected]>
Co-authored-by: Thomas Citharel <[email protected]> Signed-off-by: Pablo Zmdl <[email protected]>
kesselb
force-pushed
the
config-carddav-sync-request-timeout
branch
from
69a28ca
to
742764b
Compare
kesselb
added
3. to review
Big federated setups may need a longer timeout, which they now can configure.
This is motivated by a debugging session, in which we had to raise the timeout but could do so only via a patch.
The default timeout length doesn't change with this PR.
Checklist