Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Template field workflow #46383

Merged
merged 22 commits into from
Jul 25, 2024
Merged

feat: Template field workflow #46383

merged 22 commits into from
Jul 25, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Jul 9, 2024

Summary

This PR introduces the server API and front end changes for filling out template form controls before creating a document based on a template which has fields. If a template doesn't have fields, it will continue like the normal process before.

TODO

  • Testing -- test coverage will likely be implemented in a follow-up PR
  • Documentation -- if not updated, will also be updated in a follow-up PR

Checklist

@elzody elzody marked this pull request as ready for review July 24, 2024 23:43
@elzody elzody requested a review from skjnldsv as a code owner July 24, 2024 23:43
lib/public/Files/Template/Field.php Fixed Show fixed Hide fixed
lib/public/Files/Template/Field.php Fixed Show fixed Hide fixed
lib/public/Files/Template/Field.php Fixed Show fixed Hide fixed
@juliushaertl juliushaertl mentioned this pull request Jul 25, 2024
@juliushaertl juliushaertl changed the title feat: Template PDF workflow feat: Template field workflow Jul 25, 2024
@juliushaertl
Copy link
Member

/compile

@juliushaertl juliushaertl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 25, 2024
@juliushaertl juliushaertl added the pending documentation This pull request needs an associated documentation update label Jul 25, 2024
@skjnldsv
Copy link
Member

  • test coverage will likely be implemented in a follow-up PR

Would be really preferable 🙏

elzody added 18 commits July 25, 2024 11:11
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
@juliushaertl
Copy link
Member

/compile

Signed-off-by: nextcloud-command <[email protected]>
@juliushaertl juliushaertl added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 25, 2024
@juliushaertl juliushaertl merged commit 3d7d0b6 into master Jul 25, 2024
165 of 167 checks passed
Copy link

welcome bot commented Jul 25, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@juliushaertl juliushaertl deleted the feat/template-fields branch July 25, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish 30-feedback enhancement feature: templates feature: workflows javascript pending documentation This pull request needs an associated documentation update php Pull requests that update Php code 🍂 2024-Autumn
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants