Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FileListener): Listen to file movements across share boundaries #1126

Merged
merged 7 commits into from
Apr 18, 2024

Conversation

marcelklehr
Copy link
Member

fixes #1118

@marcelklehr marcelklehr force-pushed the fix/moving-across-share-boundaries branch from 73a1c3c to 745fa44 Compare April 17, 2024 14:03
- Catch all errors
- Don't access nodes that are non-existent

Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr marcelklehr requested a review from julien-nc April 17, 2024 16:51
Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Marcel Klehr <[email protected]>
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not familiar enough with the code to make a full in-depth review but the tests cover this change so 👍

.github/workflows/lint-php-cs.yml Show resolved Hide resolved
lib/Hooks/FileListener.php Show resolved Hide resolved
Signed-off-by: Marcel Klehr <[email protected]>
@marcelklehr marcelklehr merged commit 10b348a into main Apr 18, 2024
7 of 30 checks passed
@marcelklehr marcelklehr deleted the fix/moving-across-share-boundaries branch April 18, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recognize results are lost when transferring files to other user
2 participants