Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(psalm): Enable psalm level 3 #3258

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(psalm): Enable psalm level 3 #3258

merged 1 commit into from
Sep 20, 2024

Conversation

provokateurin
Copy link
Member

No description provided.

@provokateurin provokateurin added the 3. to review Items that need to be reviewed label Sep 19, 2024
come-nc
come-nc reviewed Sep 20, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good apart from storage private interface usage

lib/Mount/GroupMountPoint.php Outdated Show resolved Hide resolved
@provokateurin provokateurin force-pushed the fix/null-checks branch 2 times, most recently from 2e3acb5 to b7ff9b0 Compare September 20, 2024 09:05
Base automatically changed from fix/null-checks to master September 20, 2024 11:26
@provokateurin provokateurin marked this pull request as ready for review September 20, 2024 13:12
@come-nc come-nc merged commit cdd9d53 into master Sep 20, 2024
46 checks passed
@come-nc come-nc deleted the fix/psalm/level-3 branch September 20, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

Assignees
No one assigned
Labels
3. to review Items that need to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@provokateurin @come-nc