Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clearify acl overwrite behavior a bit #2828

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

icewind1991
Copy link
Member

the current wording seems to cause some confusion about when "allow" overwrites "deny" applies.

@icewind1991 icewind1991 added the 3. to review Items that need to be reviewed label Feb 22, 2024
If multiple configured advanced permissions for a single file or folder apply for a single user (such as when a user belongs to multiple groups), the "allow" permission will overwrite any "deny" permission.
Note that this only applies if both the "allow" and "deny" permission are set on the folder itself. "allow" permissions inherited from parent folder will be overwritten by an "deny" permission set on the file or folder.

Denied permissions configured for the group folder itself cannot be overwritten to "allow" permissions by the advanced permission rules.
Copy link
Member

@solracsf solracsf Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last sentence, "cannot" (setting not available) or "are not" in the sense "setting is available, but will not be applied/enforced" ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XueSheng-GIT XueSheng-GIT mentioned this pull request May 6, 2024
@skjnldsv skjnldsv added 2. developing Items that are currently under development and removed 3. to review Items that need to be reviewed labels Aug 28, 2024
@skjnldsv skjnldsv marked this pull request as draft August 30, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Items that are currently under development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants