Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't apply acls when scanning #2642

Merged
merged 1 commit into from
Jan 2, 2024
Merged

don't apply acls when scanning #2642

merged 1 commit into from
Jan 2, 2024

Conversation

icewind1991
Copy link
Member

we want to scan the full storage, even if the current user can't see all the files

@icewind1991 icewind1991 added the 3. to review Items that need to be reviewed label Nov 27, 2023
@icewind1991 icewind1991 marked this pull request as ready for review December 1, 2023 15:23
Signed-off-by: Robin Appelman <[email protected]>
@icewind1991 icewind1991 merged commit 09f0d33 into master Jan 2, 2024
37 checks passed
@icewind1991 icewind1991 deleted the no-scanner-acl branch January 2, 2024 16:56
@come-nc
Copy link
Contributor

come-nc commented Jan 9, 2024

/backport to stable28

@come-nc
Copy link
Contributor

come-nc commented Jan 9, 2024

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@come-nc
Copy link
Contributor

come-nc commented Jan 9, 2024

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@solracsf
Copy link
Member

solracsf commented Feb 1, 2024

This is causing issues with encryption: #2793

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed backport-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants