Add the selected contacts to a group #2763

MrPompom · 2022-05-30T14:54:48Z

Linked to the pull request #2756 (comment)

By using the menu of the selected contacts.

Add selected contacts in a group who already exist

When the multiselect is clicked, it will display all the group which already exists and by clicking on a group, it will add all the selected contacts to this group

Create a group and add the selected contacts

It's the same but when typing the name of the new group and press down the return key, it will create a group of this name and add the selected contacts into it

codecov · 2022-06-18T15:42:17Z

Codecov Report

Base: 67.96% // Head: 67.96% // No change to project coverage 👍

Coverage data is based on head (4d49713) compared to base (e32f12d).
Patch has no changes to coverable lines.

❗ Current head 4d49713 differs from pull request most recent head 15e64b5. Consider uploading reports for the commit 15e64b5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff            @@
##               main    #2763   +/-   ##
=========================================
  Coverage     67.96%   67.96%           
  Complexity      253      253           
=========================================
  Files            23       23           
  Lines           721      721           
=========================================
  Hits            490      490           
  Misses          231      231

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

szaimen · 2022-10-11T10:07:05Z

I just rebased this. Hopefully I didn't break anything while doing so.

src/components/ContactsList.vue

Add checkbox on hover and add a button to delete the selected contacts Signed-off-by: Bastien PROMPSY <[email protected]>

Add a button to merge the selected contacts Signed-off-by: Bastien PROMPSY <[email protected]>

When the button 'add to group' is clicked, a multiselect appears who allow to select the group or type it Signed-off-by: Bastien PROMPSY <[email protected]>

Signed-off-by: szaimen <[email protected]>

szaimen · 2022-11-08T09:56:23Z

@ChristophWurst I fixed the imports :)

ChristophWurst

First look

ChristophWurst · 2022-12-15T15:26:18Z

src/components/ContactsList.vue

+				menu-align="right">
+				<template v-if="selected.length >= 1">
+					<ActionButton v-if="showAddToGroup"
+						icon="icon-clone"


icon classes have been deprecated. please use a material icon.

ChristophWurst · 2022-12-15T15:26:31Z

src/components/ContactsList.vue

+				</template>
+				<ActionButton v-if="selected.length >= 2"
+					:close-after-click="true"
+					icon="icon-clone"


material icon required

ChristophWurst · 2022-12-15T15:26:35Z

src/components/ContactsList.vue

+				</ActionButton>
+				<ActionButton v-if="selected.length >= 1"
+					:close-after-click="true"
+					icon="icon-delete"


material icon required

ChristophWurst · 2022-12-15T15:26:52Z

src/components/ContactsList.vue

 		</div>
 		<VirtualList ref="scroller"
 			class="contacts-list"
 			data-key="key"
 			:data-sources="filteredList"
 			:data-component="ContactsListItem"
-			:estimate-size="68" />
+			:estimate-size="68"
+			:extra-props={selected}


missing quotes

ChristophWurst · 2022-12-15T15:27:02Z

src/components/ContactsList.vue


 export default {
 	name: 'ContactsList',

 	components: {
 		AppContentList,
 		VirtualList,
+		Actions,
+		ActionButton,
+		Multiselect


missing trailing comma

ChristophWurst · 2022-12-15T15:30:34Z

src/components/ContactsList.vue

+					const contactjcal = this.contacts[element].jCal[1]
+					this.addValue(firstContact, contactjcal)
+					// delete the contact merged and the uid in the selected
+					this.$store.dispatch('deleteContact', { contact: this.contacts[element] }) && this.selected.splice(this.selected.indexOf(element), 1)


await the action

ChristophWurst · 2022-12-15T15:31:02Z

src/components/ContactsList.vue

+			})
+			this.$store.dispatch('updateContact', firstContact)
+		},
+		OpenMultiselect() {


Suggested change

OpenMultiselect() {

openMultiselect() {

camel case for methods

ChristophWurst · 2022-12-15T15:31:11Z

src/components/ContactsList.vue

+				const selectedContact = this.contacts[element]
+				const data = selectedContact.groups
+				if (!data.includes(value)) {
+					this.$store.dispatch('addContactToGroup', {


await the action

ChristophWurst · 2022-12-15T15:32:59Z

src/components/ContactsList/ContactsListItem.vue

+		isUnselected() {
+			this.ischecked = false
+			// update the selected
+			this.$parent.$parent.$emit('update-check-selected', this.source.key)


accessing the grandparent is a no go. this makes the component depend on the exact structure and is prone to break in unnoticed ways. Please find a better way to pass around the data. Could you use Vuex?

ChristophWurst · 2022-12-15T15:33:20Z

src/components/ContactsList/ContactsListItem.vue

+		isSelected() {
+			this.ischecked = true
+			// update the selected
+			this.$parent.$parent.$emit('update-check-selected', this.source.key)


please don't access the grandparent component this way

szaimen requested review from st3iny and GretaD June 18, 2022 15:39

szaimen added the 3. to review Waiting for reviews label Jun 18, 2022

szaimen requested review from st3iny and removed request for st3iny October 4, 2022 23:45

szaimen force-pushed the add-to-group-the-selected-contats branch from 82fb27f to f7a792c Compare October 11, 2022 10:06

ChristophWurst reviewed Oct 17, 2022

View reviewed changes

src/components/ContactsList.vue Outdated Show resolved Hide resolved

szaimen requested a review from ChristophWurst October 17, 2022 19:43

szaimen force-pushed the add-to-group-the-selected-contats branch 2 times, most recently from 01631a5 to e2559bd Compare October 17, 2022 19:48

MrPompom and others added 4 commits October 17, 2022 21:49

Allow to delete multiple contacts

7570a1a

Add checkbox on hover and add a button to delete the selected contacts Signed-off-by: Bastien PROMPSY <[email protected]>

Allow to merge the selected contacts

5ec4f59

Add a button to merge the selected contacts Signed-off-by: Bastien PROMPSY <[email protected]>

Allow to add the selected contacts to a group

9725d38

When the button 'add to group' is clicked, a multiselect appears who allow to select the group or type it Signed-off-by: Bastien PROMPSY <[email protected]>

fix imports

15e64b5

Signed-off-by: szaimen <[email protected]>

szaimen force-pushed the add-to-group-the-selected-contats branch from e2559bd to 15e64b5 Compare October 17, 2022 19:49

ChristophWurst requested changes Dec 15, 2022

View reviewed changes

ChristophWurst marked this pull request as draft April 20, 2023 08:31

ChristophWurst added 0. to triage Pending approval or rejection. This issue is pending approval. and removed 3. to review Waiting for reviews labels Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the selected contacts to a group #2763

Add the selected contacts to a group #2763

MrPompom commented May 30, 2022

codecov bot commented Jun 18, 2022 •

edited

Loading

szaimen commented Oct 11, 2022

szaimen commented Nov 8, 2022

ChristophWurst left a comment

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

ChristophWurst Dec 15, 2022

Add the selected contacts to a group #2763

Are you sure you want to change the base?

Add the selected contacts to a group #2763

Conversation

MrPompom commented May 30, 2022

Add selected contacts in a group who already exist

Create a group and add the selected contacts

codecov bot commented Jun 18, 2022 • edited Loading

Codecov Report

szaimen commented Oct 11, 2022

szaimen commented Nov 8, 2022

ChristophWurst left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov bot commented Jun 18, 2022 •

edited

Loading