Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adapter): transistion to surrealdb@^1.0.0 #11911

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

dvanmali
Copy link

☕️ Reasoning

Moves package dependency to version 1 of the surrealdb javascript library. Package includes websocket connectivity, type safety, updates to the setup documentation, and package peer dependency change.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

#11732 - solves this by transistioning to [email protected] package. Docs state to use new connection string.
#11866 - javascript package supports surrealdb v2
#11471 - uses current surrealdb software

📌 Resources

Copy link

vercel bot commented Sep 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ❌ Failed (Inspect) Nov 8, 2024 7:27pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 7:27pm

Copy link

vercel bot commented Sep 26, 2024

@dvanmali is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters surrealdb labels Sep 26, 2024
@dvanmali dvanmali mentioned this pull request Sep 26, 2024
3 tasks
@dvanmali dvanmali changed the title Transition to surrealdb@^1.0.0 feat(adapter): transistion to surrealdb@^1.0.0 Sep 26, 2024
@dvanmali dvanmali changed the title feat(adapter): transistion to surrealdb@^1.0.0 fix(adapter): transistion to surrealdb@^1.0.0 Sep 26, 2024
Copy link

socket-security bot commented Oct 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@actions/[email protected] environment, filesystem Transitive: network +1 149 kB thboop
npm/@ariakit/[email protected] None +3 3.85 MB ariakit-bot
npm/@aws-sdk/[email protected] Transitive: environment, filesystem, shell +28 3.7 MB aws-sdk-bot
npm/@aws-sdk/[email protected] None +1 261 kB aws-sdk-bot
npm/@azure/[email protected] Transitive: environment, network +9 3.17 MB azure-sdk
npm/@balazsorban/[email protected] Transitive: environment +4 105 kB balazsorban
npm/@builder.io/[email protected] eval, network 0 2.37 MB adamdbradley
npm/@builder.io/[email protected] eval 0 45.6 MB shairez
npm/@cloudflare/[email protected] None 0 2.69 MB wrangler-publisher
npm/@eslint/[email protected] None 0 47.7 kB eslintbot
npm/@eslint/[email protected] None 0 14.2 kB eslintbot
npm/@graphql-codegen/[email protected] environment, filesystem, network, shell, unsafe +10 5.37 MB dotansimha
npm/@graphql-codegen/[email protected] Transitive: environment, unsafe +15 4.85 MB dotansimha
npm/@radix-ui/[email protected] None +4 91 kB chancestrickland
npm/@radix-ui/[email protected] None +9 173 kB chancestrickland
npm/@radix-ui/[email protected] Transitive: environment +40 1.76 MB chancestrickland
npm/@radix-ui/[email protected] None +16 506 kB chancestrickland
npm/@radix-ui/[email protected] None +1 33.2 kB vladmoroz
npm/@simplewebauthn/[email protected] network +18 2.11 MB iamkale
npm/@types/[email protected] None 0 0 B
npm/@types/[email protected] None +2 1.69 MB types
npm/@vercel/[email protected] environment Transitive: network +2 778 kB vercel-release-bot
npm/[email protected] None +1 15.7 kB joebell93
npm/[email protected] None 0 8.55 kB lukeed
npm/[email protected] None 0 19.6 MB ericfennis
npm/[email protected] environment Transitive: network +5 3.45 MB balazsorban
npm/[email protected] environment, filesystem, network, shell, unsafe Transitive: eval +45 1.44 GB vercel-release-bot
npm/[email protected] environment +3 4.63 MB react-bot
npm/[email protected] environment +2 339 kB react-bot
npm/[email protected] environment 0 765 kB dcas
npm/[email protected] None 0 18.1 kB thejameskyle
npm/[email protected] Transitive: environment, filesystem, network, shell +64 16.8 MB pi0

🚮 Removed packages: npm/@auth/[email protected], npm/@auth/[email protected], npm/@solidjs/[email protected], npm/@solidjs/[email protected], npm/@sveltejs/[email protected], npm/@sveltejs/[email protected], npm/@sveltejs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@liamwh
Copy link
Contributor

liamwh commented Oct 7, 2024

Any updates on this PR? Would love to see it merged so we can use SurrealDB with Auth.js!

@dvanmali
Copy link
Author

dvanmali commented Oct 9, 2024

Any updates on this PR? Would love to see it merged so we can use SurrealDB with Auth.js!

Package is ready to go. Still waiting for PR to merge.

@ubbe-xyz @ndom91

@applied-mathematician
Copy link

Bump. I'm waiting for this PR to use Auth.js since I'm using Surrealdb.

@ndom91
Copy link
Member

ndom91 commented Nov 9, 2024

This is breaking, right? Well have to make sure we bump the surreal adapter appropriately

@dvanmali
Copy link
Author

ndom91 This is breaking, right? Well have to make sure we bump the surreal adapter appropriately

Yes, this is a breaking update because the underlying storage layer and transmission layer are now both typed. Thus this package jumps to version 2.0.0 with surrealdb@^1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters Changes related to the core code concerning database adapters surrealdb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants