feat : 로또 2등 추가 #3952
Open
feat : 로또 2등 추가 #3952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nooose
requested changes
Oct 24, 2024
Comment on lines
+26
to
34
| public LottoDetailMatch countMatches(Lotto winningNumbers, int bonusNumber) { | ||
| int matchCount = (int) numbers.stream() | ||
| .filter(winningNumbers.getNumbers()::contains) | ||
| .count(); | ||
|
|
||
| boolean isMatchedBonusNumber = bonusNumber != 0 && numbers.contains(bonusNumber); | ||
|
|
||
| return new LottoDetailMatch(matchCount, isMatchedBonusNumber) ; | ||
| } |
There was a problem hiding this comment.
LottoDetailMatch을 통해서 일치한 수를 반환한 것도 좋아보이지만,
작성하신 LottoRank 를 반환하도록 만들어보면 코드 흐름이 자연스럽게 흘러갈 것으로 보이네요 😄
| .collect(Collectors.toList()); | ||
| return countMatch(matchResult); | ||
| } | ||
| // 순위에 맞게 몇개 일치하는지 갯수를 센다 |
There was a problem hiding this comment.
TODO나 FIXME 같은 주석 태그가 아니라면 주석을 지양하는 것이 좋을 것 같아요
메소드 네이밍만으로 해석이 가능하도록 작성하는 것이 첫번째이고,
그래도 부족하다면 java doc 문법을 활용해서 메소드를 설명하는 것이 좋다고 생각합니다.
/**
* 테스트 메소드
*/
public test() {
}
| @@ -27,11 +28,11 @@ public static void gameStart() { | |||
| lottoPrint.lottoPurchasedCount(lottoTickets); | |||
There was a problem hiding this comment.
로또 번호(16)와 보너스 번호(16)가 중복되는 상황이네요
이 부분도 확인 부탁드립니다!
| @@ -23,10 +23,14 @@ public Set<Integer> getNumbers() { | |||
| return this.numbers; | |||
There was a problem hiding this comment.
모든 원시값과 문자열을 포장
로또안에 있는 Integer도 1~45 숫자만 허용하는 객체로 만들어보면 좋겠습니다.
그럼 Lotto가 가진 책임을 덜어낼 수 있겠네요
There was a problem hiding this comment.
로또에 대한 단위 테스트가 약간 부족하다고 느껴집니다.
사소한 단위 테스트도 학습 차원에서 만들어 보면 좋을 것 같아요 😀
- 숫자 범위 검증
- 번호 6개가 아닐 때 예외 검증
- ...
|
|
||
| private final int count; | ||
| private final String rank; | ||
| private final long amount; | ||
| private final boolean requireBonus; |
| , THIRD_PRIZE (5, "3", 1500000, false) | ||
| , FOURTH_PRIZE (4, "4", 50000, false) | ||
| , FIFTH_PRIZE (3, "5", 5000, false) | ||
| , NON_WINNER (0, "낙첨", 0, false); | ||
|
|
||
| private final int count; | ||
| private final String rank; |
|
이번 미션 커밋은 하나였는데요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
리뷰요청드립니다.