🚀 4단계 - 로또(수동) #3561
Open
🚀 4단계 - 로또(수동) #3561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyucumber
requested changes
Dec 13, 2023
| List<Lotto> lottos = Lotto.puchase(money); | ||
| int totalCount = money / Lotto.LOTTO_PRICE; | ||
| int countOfManual = InputView.countOfManual(); | ||
| List<String> manualLottos = InputView.purchaseManual(countOfManual); |
There was a problem hiding this comment.
중요한 부분은 아니지만, Lotto라는 클래스가 있으므로 헷갈리지 않게 manualLottosText 등의 변수명을 가지는건 어떨까요?
Comment on lines
+35
to
+49
| public static List<Lotto> puchaseAuto(int count) { | ||
| List<Lotto> lottos = new ArrayList<>(); | ||
| for (int i = 0; i < count; ++i) { | ||
| lottos.add(new Lotto(new LottoNumbers())); | ||
| } | ||
| return lottos; | ||
| } | ||
|
|
||
| public static List<Lotto> puchaseManual(List<String> lottoNumbers) { | ||
| List<Lotto> lottos = new ArrayList<>(); | ||
| for (String lottoNumber : lottoNumbers) { | ||
| lottos.add(new Lotto(new LottoNumbers(lottoNumber))); | ||
| } | ||
| return lottos; | ||
| } |
There was a problem hiding this comment.
수동과 자동 List<Lotto>를 생성하는 책임을 Lotto가 가지게 되었네요.
다소 과할 순 있지만 책임이 늘어남에 따라 Lottos와 같은 일급 컬렉션 형태로 묶은 다음에 해당 클래스로 책임을 옮겨갈 수 있습니다. Result나 이런 부분에서도 List<Lotto>를 쓰고 있을텐데 필요에 따라 추출해볼 수 있을 것 같네요.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.