[사다리 미션] 황현식 미션 제출합니다. #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+31
to
+35
| private List<User> generateUsers(List<String> users) { | ||
| return users.stream() | ||
| .map(user -> new User(user, users.indexOf(user))) | ||
| .toList(); | ||
| } |
There was a problem hiding this comment.
최대한 기능 단위로 쪼개보려고 분리했습니다!
이 정도는 메서드 분리 안하고 InputView에서 바로 처리하는 것도 좋아보이네요
|
|
||
| public class LadderGame { | ||
|
|
||
| private final LadderMaker ladderMaker = new LadderMaker(); |
| return user; | ||
| } | ||
|
|
||
| public int move(int position, Line line) { |
There was a problem hiding this comment.
처음엔 당연히 게임에서 움직이는 거라 생각했었는데 사다리의 역할로 볼 수도 있겠네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
코드는 잘 돌아가는데 리팩터링을 크게 못한 것 같아 아쉽네요.
최대한 간결하게 짠다고 짠 것 같은데 여전히 복잡한 느낌..
수정할 부분 피드백 부탁드립니다!