Compile sdk #62
Merged
Compile sdk #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 27, 2024 12:54
detect indirect dependency cycles
- escape class names - decay type names for lookup
- not done: generate includes
code never activated (in CS2)
to prevent the case where both resolvers don't resolve a dependency
it is the last user
sdk compiles!
code never triggers in CS2
Merged
|
@es3n1n merge? |
Hi, there is still some work that we have to do first before merging. I will take a look at it next week hopefully 🫣 |
|
Tweaked a few things, add some missing types and now it works as expected on my machine too.
Looks like we're good to go. |
es3n1n
approved these changes
Sep 10, 2024
cpz
approved these changes
Sep 10, 2024
|
yay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
Depends on #58
static_assertions for type sizes and field offsets where possible, which pass (Tested with CS2 9035763 on Linux)Additionally, for testing purposes, I added a conan recipe to the SDK. The generated conan package works, but there are some properties we should set dynamically. There's a TODO in the recipe and conan isn't advertised in the README, so we can do it that a follow-up issue.