-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] use g_fork_execvp instead of g_fork #2598
base: devel
Are you sure you want to change the base?
[WIP] use g_fork_execvp instead of g_fork #2598
Conversation
…for child_arguments
…ystem instead TODO: implement log_restart_from(int log_fd, ...)
Hi @unstabler This is going along the right lines, and for the reasons you state regarding MacOS, we need to get this functionality in one way or another. There's a couple of things you haven't considered which will need to be included in a complete solution:-
I'm currently focussed on getting sesman split into two for xrdp v1.x. This will mean I'm going to need to cover all of the above in sesman anyway, so I suggest we hold off on this one until I've got that done. I've probably missed a few things, and we'll find those during testing. Regarding your existing code, you can simplify things by ditching the |
DESCRIPTION
fork()
.fork()
.CHANGES
g_fork_execvp(exec, argv)
has addedg_get_executable_path(exectype, buf, bufsize)
has addedxrdp
now accepts--child-process
and--child-fd [fd]
, entrypoint for child process also addedxrdp
will useg_fork_execvp()
instead ofg_fork()
for accepting new connectionsTODO
logger->fd
to child process (via argv, or ...), as i reconstructedstruct trans
?xrdp_listen.c:814
...struct xrdp_process *
,struct trans *
afterxrdp_process_main_loop
translated from:
ですが、かなりコアなコードが修正されたのに、改善される事項は上記の一つしかいないと思うので、もし必要にならないと思われた場合は気楽にこのPRをクローズしても結構です。