Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate main package vignette #2

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Populate main package vignette #2

merged 4 commits into from
Apr 19, 2024

Conversation

HDash
Copy link
Collaborator

@HDash HDash commented Apr 17, 2024

Initial draft - Issue #1

@HDash HDash added documentation Improvements or additions to documentation enhancement New feature or request labels Apr 17, 2024
@HDash HDash requested a review from Tomrrr1 April 17, 2024 10:45
@HDash HDash self-assigned this Apr 17, 2024
@Tomrrr1 Tomrrr1 marked this pull request as ready for review April 17, 2024 10:57
@HDash
Copy link
Collaborator Author

HDash commented Apr 17, 2024

rworkflows checks failing for unrelated reasons.

Error:

remote: Permission to neurogenomics/MotifStats.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/neurogenomics/MotifStats.git/': The requested URL returned error: 403

Tomrrr1
Tomrrr1 requested changes Apr 18, 2024
View reviewed changes
vignettes/MotifStats.Rmd Outdated Show resolved Hide resolved
vignettes/MotifStats.Rmd Show resolved Hide resolved
vignettes/MotifStats.Rmd Outdated Show resolved Hide resolved
vignettes/MotifStats.Rmd Outdated Show resolved Hide resolved
vignettes/MotifStats.Rmd Outdated Show resolved Hide resolved
vignettes/MotifStats.Rmd Show resolved Hide resolved
vignettes/MotifStats.Rmd Show resolved Hide resolved
vignettes/MotifStats.Rmd Outdated Show resolved Hide resolved
vignettes/MotifStats.Rmd Show resolved Hide resolved
HDash
HDash commented Apr 18, 2024
View reviewed changes
Copy link
Collaborator Author

@HDash HDash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct typos and improved documentation. Additionally, change the run_Ame output directory behaviour to follow the roxygen out_dir parameter documentation.

@HDash HDash requested a review from Tomrrr1 April 18, 2024 16:23
Tomrrr1
Tomrrr1 approved these changes Apr 19, 2024
View reviewed changes
R/peak_proportion.R
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

@Tomrrr1 Tomrrr1 merged commit 86c88ec into neurogenomics:main Apr 19, 2024
1 check failed
@HDash HDash mentioned this pull request Apr 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomrrr1 Tomrrr1 Tomrrr1 approved these changes

Assignees

@HDash HDash

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HDash @Tomrrr1