-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor network events to return list of maps instead of strings #458
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1898462
to
f1f8f9d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
==========================================
- Coverage 30.13% 29.65% -0.49%
==========================================
Files 50 50
Lines 4081 4863 +782
==========================================
+ Hits 1230 1442 +212
- Misses 2745 3316 +571
+ Partials 106 105 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
f1f8f9d
to
dadc2d4
Compare
dadc2d4
to
3c9c003
Compare
3c9c003
to
4508e61
Compare
4508e61
to
c802238
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2f889b8 make set-agent-image |
c802238
to
2b70933
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=18481c0 make set-agent-image |
2b70933
to
f39deb8
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=2c10edc make set-agent-image |
f39deb8
to
dbc88d5
Compare
/ok-to-test |
New image: It will expire after two weeks. To deploy this build, run from the operator repo, assuming the operator is running: USER=netobserv VERSION=9e969bf make set-agent-image |
Signed-off-by: Mohamed Mahmoud <[email protected]>
dbc88d5
to
e922690
Compare
Description
Network events was orignally decode as string with this recent ovnk lib it will come as struct and the agent need to generate list of configmaps with those events
this effort to allow generating metrics with network events
Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.