Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parameter-metadata-accessor.ts #3208

Merged
merged 6 commits into from
Dec 17, 2024
Merged

Conversation

Makkalay
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kamilmysliwiec
Copy link
Member

image

@kamilmysliwiec
Copy link
Member

PS: Fount I updated "path-to-regexp" to "^8.0.0" from 3.0.0

You shouldn't be doing that yet. See this PR #3199

but I need to do something like

Why?

@kamilmysliwiec
Copy link
Member

path-to-regexp v8 isn't compatible with Nest v10

@kamilmysliwiec kamilmysliwiec merged commit 9ff9ba0 into nestjs:master Dec 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants