Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): less verbose 'missing package' error message #13753

Merged
merged 2 commits into from
Jul 4, 2024
Merged

feat(common): less verbose 'missing package' error message #13753

merged 2 commits into from
Jul 4, 2024

Conversation

micalevisk
Copy link
Member

@micalevisk
feat(common): less verbose 'missing package' error message
9b4aa27 
The tip "npm install ..." is not that useful when one is using another package manager instead of NPM. And also can lead to confusion.
@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 798c04a3-10c5-4b05-9b71-39bfe6094231

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 92.207%
Files with Coverage Reduction New Missed Lines %
packages/core/scanner.ts 2 88.46%
Totals Coverage Status
Change from base Build fcad1efa-4531-401f-bd98-b99ccb5d8ae2: -0.001%
Covered Lines: 6744
Relevant Lines: 7314
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 7462be7f-0996-4a67-a2ea-5acfadc503a3

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.001%) to 92.207%
Files with Coverage Reduction New Missed Lines %
packages/core/scanner.ts 2 88.46%
Totals Coverage Status
Change from base Build fcad1efa-4531-401f-bd98-b99ccb5d8ae2: -0.001%
Covered Lines: 6744
Relevant Lines: 7314
💛 - Coveralls

@kamilmysliwiec kamilmysliwiec merged commit b384aad into nestjs:master Jul 4, 2024
5 checks passed
@kamilmysliwiec
Copy link
Member

lgtm

@micalevisk micalevisk deleted the patch-1 branch July 4, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micalevisk @coveralls @kamilmysliwiec