-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(): update the dependencies mercurius for compatibility with fastify v5.x 🔥 #3407
base: master
Are you sure you want to change the base?
chore(): update the dependencies mercurius for compatibility with fastify v5.x 🔥 #3407
Conversation
9091319
to
5f03554
Compare
5f03554
to
534ed92
Compare
Tests fail due to this error: |
I think this is a problem with Jest. Jest supports ECMAScript (ESM) modules from version 27.x, but full support for ESM, particularly dynamic imports, requires proper configuration, perhaps some configuration is missing? 🤔 |
There's an issue raised in mercurius: mercurius-js/mercurius#1122 Seems that Jest is to blame, which is unfortunate, since I'm pretty sure Nest won't move to a different testing environment because of single dependency. As noted in the upstream issue, such cases will probably arise as lib maintainers join the ESM-only hype train. Edit: the only mention I found is in "using ESM package sample". Edit 2: created a pr for the pr Tony133#1 with the suggested change from the sample. Not sure whether that fixes the tests completely. |
cbe0129
to
591cb68
Compare
@wodCZ your solution seems to work, only 4 tests fail ( see screenshot ) I have updated the dependencies of fastify and mercurius, now there are these versions:
|
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number:
What is the new behavior?
Proposal:
Does this PR introduce a breaking change?
Other information