Merge Request for issue 129 #142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upgraded nestjs versions rewrited upload feature added download feature added delete feature
* fixed url encoding for blobName with characters of: / and spacebar (and others).
…ble stream (for uploading with onProgress.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: 129 #129
What is the new behavior?
Does this PR introduce a breaking change?
There are breaking changes in tests that i could not fix. also it adds some new features but i dont remember now as im using it already for quite time and need to do differential now
As i see in comparrison i modified the upload meta file interface (making it smaller) i think i should bring it back to way it was but add question marks to it for not requiring all of the interface properties (like in new one)
Other information