fix: p2p alerts are not filterred in block chain info #3802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The root cause is that when launcher passes client version to alert notifier, it uses the full format such as `0.107.0-rc1 (1b3e6b1 2023-01-12)`. However, the notifier internal uses semver to parse the version directly. If it fails, it will consider all alerts as effective. The solution: The launcher pass the short version format to alert notifier.
zhangsoledad
approved these changes
Jan 17, 2023
bors bot
added a commit
that referenced
this pull request
Jan 18, 2023
3803: [hotfix 0.107.x] fix: p2p alerts are not filterred in block chain info r=zhangsoledad a=doitian Rebase #3802 to v0.107.* Merge #3804 first, which has upgraded tokio for https://rustsec.org/advisories/RUSTSEC-2023-0001 Co-authored-by: ian <[email protected]> Co-authored-by: zhangsoledad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
The alerts returned in RPC
get_blockchain_infowill return all the alerts.The expected behavior is that is should filter based on the alert version range requirements.
Related: #3800 (comment)
What is changed and how it works?
What's Changed:
The root cause is that when launcher passes client version to alert notifier, it uses the full format such as
0.107.0-rc1 (1b3e6b1 2023-01-12). However, the notifier internal uses semver to parse the version directly. If it fails, it will consider all alerts as effective.The solution: The launcher pass the short version format to alert notifier.
Check List
Tests
get_blockchain_infockb v0.105.*.Release note