Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 508 14 #1600

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Issue 508 14 #1600

merged 3 commits into from
Jan 22, 2024

Conversation

zmcNotafraid
Copy link
Collaborator

@zmcNotafraid zmcNotafraid commented Jan 19, 2024

When inscription start rebase, we bind new inscription with old inscription through pre_udt_hash.In index page, we need to filter old inscription, keep new inscription.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (f373f6b) 67.56% compared to head (02c912f) 67.18%.
Report is 11 commits behind head on develop.

❗ Current head 02c912f differs from pull request most recent head a587833. Consider uploading reports for the commit a587833 to get more accurate results

Files Patch % Lines
app/workers/generate_cell_dependencies_worker.rb 30.76% 9 Missing ⚠️
...ontrollers/api/v1/omiga_inscriptions_controller.rb 90.00% 1 Missing ⚠️
app/models/ckb_sync/new_node_data_processor.rb 98.52% 1 Missing ⚠️
app/utils/ckb_utils.rb 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1600      +/-   ##
===========================================
- Coverage    67.56%   67.18%   -0.38%     
===========================================
  Files          289      290       +1     
  Lines         7944     7969      +25     
===========================================
- Hits          5367     5354      -13     
- Misses        2577     2615      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Miles Zhang <[email protected]>
@zmcNotafraid zmcNotafraid added this pull request to the merge queue Jan 22, 2024
Merged via the queue into nervosnetwork:develop with commit d8c479b Jan 22, 2024
1 check passed
@zmcNotafraid zmcNotafraid deleted the issue-508-14 branch January 22, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants