Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bqls): Add bqls support #3486

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joshbode
Copy link

@joshbode joshbode commented Dec 1, 2024

Adds support for BigQuery language server.

thanks @kitagry

@joshbode joshbode requested a review from glepnir as a code owner December 1, 2024 21:53
@joshbode joshbode force-pushed the joshbode/bqls branch 2 times, most recently from 15797b0 to 55d2e7e Compare December 1, 2024 21:57
@glepnir
Copy link
Member

glepnir commented Dec 2, 2024

Thanks. But we have some rules for new servers. Please see https://github.com/neovim/nvim-lspconfig/blob/master/CONTRIBUTING.md#adding-a-server-to-lspconfig

could you provide some more information about this server how popular it is

@joshbode
Copy link
Author

joshbode commented Dec 2, 2024

I would say not very popular (yet!) but maybe @kitagry has some more context (there is a plugin that adds the config dynamically).

I was hoping that adding support would increase the exposure of this LS, which appears to provide better support for BigQuery than the existing sqlls server.

@glepnir
Copy link
Member

glepnir commented Dec 3, 2024

It's a great server. But it's only 7 stars at the moment. And it doesn't have the same download volume as other editors like vscode. So I think we can wait a little longer to avoid our repo becoming bloated with some small and unpopular server configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants