feat(stylelint): add StylelintFixAll command

[bennypowers]

see bmatcuk/stylelint-lsp#29 (comment)

[justinmk]

This kind of thing is why in #1937 I'm very hesitant to add these special-case commands to each lspconfig. It's unpleasant for users to have a different interface or every random command. Here we have a function with an "async" flag. Looks like it's always true currently. This is a lot of code, and only for one command. I don't see how we can maintain 100s of configs with this much code.

[bennypowers]

for the record I don't like either of these commands and I think both are workarounds.

That being said, I just want to fix my stylelint errors on save. I have no idea why autoFixOnSave and autoFixOnFormat are not respected, but this config and an aucmd will will solve the problem for users.

[gegoune]

@bennypowers

require('lspconfig')['stylelint_lsp'].setup({
    settings = {
      stylelintplus = {
        autoFixOnFormat = true,
      },
    },
})

plus lukas-reineke/lsp-format.nvim seems to be fixing stylelint errors for me.

[bennypowers]

Thanks for the link, but this pr is for support in lspconfig without an additional plugin

I'm definitely going to check that out for my own config tho

[bennypowers]

I agree with @glepnir and @justinmk's comments about how bloated this repo is and that the goal should be to release language-specific plugins

That being said, I still think this should be merged, in order to support the simple user who just wants to format and fix their file on save, rather than telling them to wait for a big rewrite.

[glepnir]

@bennypowers if this is a necessary improve it can be :) I am not familiar the stylelint need check and test it .if anyone can give some advice very thanks then.

[bennypowers]

set neovim up as described in this pr (with autocmds), then

git clone https://github.com/bennypowers/nvim-stylelint-repro
cd nvim-stylelint-repro
npm ci
nvim styles.css

write file

expect file contents to equal

body {
  background-color: red;
}

[glepnir]

but as the justin said there has vim.lsp.handler and opts. sync so I need follow the justin his advice.

[justinmk]

That being said, I still think this should be merged, in order to support the simple user who just wants to format and fix their file on save, rather than telling them to wait for a big rewrite.

That's always the justification provided for each of these new features. This is how scope-creep occurs.

Not seeing a strong justification here.

We need a very thin approach (2-3 lines of code, not 50+ as in this PR) to adding support for custom (off-spec) server features. Until that happens (perhaps never), we need to stop adding custom commands. #1937