BUGFIX: Don’t load the same files twice in the static resource collection #3418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion The second pattern included a 99% subset of the first pattern except the files in the public folders themselves. Therefore all files in subfolders were loaded twice in the \Neos\Flow\ResourceManagement\Collection::getObjects method and aftterwards also published twice. Resolves: #3417
kdambekalns
approved these changes
Nov 20, 2024
mhsdesign
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second pattern included a 99% subset of the first pattern except the files in the public folders themselves. Therefore all files in subfolders were loaded twice in the
\Neos\Flow\ResourceManagement\Collection::getObjectsmethod and afterwards also published twice.In a medium sized project the first pattern loaded 1165 files and the second pattern 1155 which were all duplicates.
An additional change is required to deduplicate paths loaded in the
Collectionclass to prevent further configuration regressions for cases like this.Resolves: #3417
Review instructions
Web/_Resources/Staticfolder in a demo distribution./flow resource:publish --collection static