Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Update PhpUnit #3405

Draft
wants to merge 9 commits into
base: 8.3
Choose a base branch
from
Draft

TASK: Update PhpUnit #3405

wants to merge 9 commits into from

Conversation

kdambekalns
Copy link
Member

@kdambekalns kdambekalns commented Oct 25, 2024 •
edited
Loading

Allow newer PhpUnit versions and adjust tests as needed.

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@kdambekalns kdambekalns self-assigned this Oct 25, 2024
@github-actions github-actions bot added the 8.3 label Oct 25, 2024
@kdambekalns kdambekalns changed the title Task/update phpunit TASK: Update PhpUnit Oct 25, 2024
@github-actions github-actions bot added the Task label Oct 25, 2024
kitsunet and others added 5 commits November 5, 2024 18:28
@kitsunet
Use onlyMethods and willReturn in phpunit tests
620d9a1
@kdambekalns
TASK: Delete empty test case that probably never will filled
a3f95f7
@kdambekalns
TASK: Adjust dataProviders to be static
d148617
@kdambekalns
TASK: Drop use of getName() in FunctionalTestCase
19ac0ef 
This is not part of the PhpUnit API and has changed to `name()` in
PHPUnit 11. Rather not use it, than add a version check…
@kdambekalns
TASK: Drop runBare() override from StandaloneViewTest
cd75bfb 
As of PHPUnit 11 `runBare()` is a `final` method.

This was written ages ago by Sebastian Kurfürst, who recently said:

> IMHO we wanted to run each test twice to run it without cache and
> then with cache. But it seems this was broken anyways since a long
> time – so we can drop it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kdambekalns kdambekalns

Labels
8.3 Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kdambekalns @kitsunet