Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow arbitrary config params with more efficient repr #30

Merged
merged 12 commits into from
Jun 20, 2024

Conversation

conradludgate
Copy link

No description provided.

Copy link

@khanova khanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Btw, do you think, we should merge origin into our fork at some point?

@@ -588,17 +579,6 @@ impl Config {
};
self.channel_binding(channel_binding);
}
"replication" => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove it from there?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback branch will handle it

@conradludgate
Copy link
Author

Btw, do you think, we should merge origin into our fork at some point?

Yeah, although much easier said than done. 😭

@conradludgate conradludgate merged commit cff6927 into neon Jun 20, 2024
3 checks passed
@conradludgate conradludgate deleted the config-changes branch June 20, 2024 10:10
VladLazar added a commit that referenced this pull request Nov 13, 2024
VladLazar added a commit that referenced this pull request Nov 13, 2024
VladLazar added a commit that referenced this pull request Nov 14, 2024
…#31)

* Revert "allow arbitrary config params with more efficient repr (#30)"

This reverts commit cff6927.

* ci: fix clippy lints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants