Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add checkout depth1 to workflow to access local github actions like generate allure report #8259

Merged
merged 5 commits into from
Jul 4, 2024

Conversation

Bodobolero
Copy link
Contributor

@Bodobolero Bodobolero commented Jul 4, 2024

Problem

job step to create allure report fails

https://github.com/neondatabase/neon/actions/runs/9781886710/job/27006997416#step:11:1

Summary of changes

Shallow checkout of sources to get access to local github action needed in the job step

Example run

example run with this change https://github.com/neondatabase/neon/actions/runs/9790647724
do not merge this PR until the job is clean

@Bodobolero Bodobolero requested a review from bayandin July 4, 2024 08:00
Copy link

github-actions bot commented Jul 4, 2024

3018 tests run: 2903 passed, 0 failed, 115 skipped (full report)


Code coverage* (full report)

  • functions: 32.6% (6932 of 21268 functions)
  • lines: 50.0% (54468 of 108884 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
d54da55 at 2024-07-04T19:50:33.653Z :recycle:

Copy link
Member

@bayandin bayandin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to clarify, to create an allure report by ./.github/actions/allure-report-generate we need to upload allure results (from tests) by ./.github/actions/allure-report-store first.
For the regular tests/benchmarks it is done in .github/actions/run-python-test-set, do we do the same for Periodic pagebench?

@Bodobolero
Copy link
Contributor Author

do we do the same for Periodic pagebench?

Yes we do here https://github.com/neondatabase/ec2_test_runner/blob/main/pagebench/upload_allure_report.sh

@Bodobolero Bodobolero requested a review from bayandin July 4, 2024 09:49
.github/workflows/periodic_pagebench.yml Outdated Show resolved Hide resolved
.github/workflows/periodic_pagebench.yml Outdated Show resolved Hide resolved
@Bodobolero Bodobolero merged commit 711716c into main Jul 4, 2024
69 checks passed
@Bodobolero Bodobolero deleted the bodobolero/fix_allure_jobstep_pagebench branch July 4, 2024 20:17
@Bodobolero
Copy link
Contributor Author

successful run with allure report https://github.com/neondatabase/neon/actions/runs/9799530541

VladLazar pushed a commit that referenced this pull request Jul 8, 2024
…enerate allure report (#8259)

## Problem

job step to create allure report fails


https://github.com/neondatabase/neon/actions/runs/9781886710/job/27006997416#step:11:1

## Summary of changes

Shallow checkout of sources to get access to local github action needed
in the job step

## Example run 
example run with this change
https://github.com/neondatabase/neon/actions/runs/9790647724
do not merge this PR until the job is clean

---------

Co-authored-by: Alexander Bayandin <[email protected]>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
…enerate allure report (#8259)

## Problem

job step to create allure report fails


https://github.com/neondatabase/neon/actions/runs/9781886710/job/27006997416#step:11:1

## Summary of changes

Shallow checkout of sources to get access to local github action needed
in the job step

## Example run 
example run with this change
https://github.com/neondatabase/neon/actions/runs/9790647724
do not merge this PR until the job is clean

---------

Co-authored-by: Alexander Bayandin <[email protected]>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
…enerate allure report (#8259)

## Problem

job step to create allure report fails


https://github.com/neondatabase/neon/actions/runs/9781886710/job/27006997416#step:11:1

## Summary of changes

Shallow checkout of sources to get access to local github action needed
in the job step

## Example run 
example run with this change
https://github.com/neondatabase/neon/actions/runs/9790647724
do not merge this PR until the job is clean

---------

Co-authored-by: Alexander Bayandin <[email protected]>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
…enerate allure report (#8259)

## Problem

job step to create allure report fails


https://github.com/neondatabase/neon/actions/runs/9781886710/job/27006997416#step:11:1

## Summary of changes

Shallow checkout of sources to get access to local github action needed
in the job step

## Example run 
example run with this change
https://github.com/neondatabase/neon/actions/runs/9790647724
do not merge this PR until the job is clean

---------

Co-authored-by: Alexander Bayandin <[email protected]>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
…enerate allure report (#8259)

## Problem

job step to create allure report fails


https://github.com/neondatabase/neon/actions/runs/9781886710/job/27006997416#step:11:1

## Summary of changes

Shallow checkout of sources to get access to local github action needed
in the job step

## Example run 
example run with this change
https://github.com/neondatabase/neon/actions/runs/9790647724
do not merge this PR until the job is clean

---------

Co-authored-by: Alexander Bayandin <[email protected]>
VladLazar pushed a commit that referenced this pull request Jul 8, 2024
…enerate allure report (#8259)

## Problem

job step to create allure report fails


https://github.com/neondatabase/neon/actions/runs/9781886710/job/27006997416#step:11:1

## Summary of changes

Shallow checkout of sources to get access to local github action needed
in the job step

## Example run 
example run with this change
https://github.com/neondatabase/neon/actions/runs/9790647724
do not merge this PR until the job is clean

---------

Co-authored-by: Alexander Bayandin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants