Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: Dynamic project does not properly deal with detached configurations #252

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

marchermans
Copy link
Contributor

In 7.0.166 we switched back to detached configurations, but I missed some extendsFrom clauses which cause issues when generating the installer, because that uses extendsFrom to resolve consistently with the runtime.

Adds a test that covers a round trip of the installer, which ensures that this can not happen again.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 4, 2024

  • Publish PR to GitHub Packages

Last commit published: 8e3b851a921ef229ee68bf95d7deb946fe7043d0.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #252' // https://github.com/neoforged/NeoGradle/pull/252
        url 'https://prmaven.neoforged.net/NeoGradle/pr252'
        content {
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle', 'test-utils')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle', 'userdev')
        }
    }
}

@marchermans marchermans merged commit 7ba0e47 into NG_7.0 Nov 4, 2024
115 of 116 checks passed
@marchermans marchermans deleted the fix/dyn-project-config-use branch November 4, 2024 10:38
@neoforged-releases
Copy link

🚀 This PR has been released as NeoGradle version 7.0.168.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant