Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] LCP writer not properly de-duplicating dependencies #244

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

marchermans
Copy link
Contributor

This creates a new temporary configuration that is then used to resolve all the LCP entries (except the actual MC jar) to run the game with.

Using a configuration ensures that the dependencies are not duplicated if they have different versions.

…t was directly adding them to a CFC, instead of through a config.
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Sep 22, 2024

  • Publish PR to GitHub Packages

Last commit published: 86d5cc18126faa081381cc8a3082090853456ed7.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #244' // https://github.com/neoforged/NeoGradle/pull/244
        url 'https://prmaven.neoforged.net/NeoGradle/pr244'
        content {
            includeModule('net.neoforged.gradle', 'common')
            includeModule('net.neoforged.gradle.common', 'net.neoforged.gradle.common.gradle.plugin')
            includeModule('net.neoforged.gradle', 'dsl-common')
            includeModule('net.neoforged.gradle', 'dsl-neoform')
            includeModule('net.neoforged.gradle', 'dsl-mixin')
            includeModule('net.neoforged.gradle', 'dsl-platform')
            includeModule('net.neoforged.gradle', 'dsl-userdev')
            includeModule('net.neoforged.gradle', 'dsl-vanilla')
            includeModule('net.neoforged.gradle', 'neoform')
            includeModule('net.neoforged.gradle.neoform', 'net.neoforged.gradle.neoform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'mixin')
            includeModule('net.neoforged.gradle.mixin', 'net.neoforged.gradle.mixin.gradle.plugin')
            includeModule('net.neoforged.gradle.platform', 'net.neoforged.gradle.platform.gradle.plugin')
            includeModule('net.neoforged.gradle', 'utils')
            includeModule('net.neoforged.gradle.userdev', 'net.neoforged.gradle.userdev.gradle.plugin')
            includeModule('net.neoforged.gradle', 'platform')
            includeModule('net.neoforged.gradle', 'userdev')
            includeModule('net.neoforged.gradle.vanilla', 'net.neoforged.gradle.vanilla.gradle.plugin')
            includeModule('net.neoforged.gradle', 'vanilla')
            includeModule('net.neoforged.gradle', 'test-utils')
        }
    }
}

@marchermans marchermans merged commit 89bae0f into NG_7.0 Sep 22, 2024
112 checks passed
@marchermans marchermans deleted the fix/classpath-multiversion branch September 22, 2024 14:13
@neoforged-releases
Copy link

🚀 This PR has been released as NeoGradle version 7.0.165.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module named org.objectweb.asm.tree.analysis was already on the JVMs module path
1 participant