-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A simpler impl for ByteArrayEqualityComparer
and remove redundant impl
#3562
Merged
shargon
merged 9 commits into
neo-project:master
from
nan01ab:fea.ByteArrayEqualityComparer-optimization
Nov 9, 2024
Merged
A simpler impl for ByteArrayEqualityComparer
and remove redundant impl
#3562
shargon
merged 9 commits into
neo-project:master
from
nan01ab:fea.ByteArrayEqualityComparer-optimization
Nov 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A better and simpler impl for ByteArrayEqualityComparer
nan01ab
changed the title
A better and simpler implementation for
A simpler impl for Nov 1, 2024
ByteArrayEqualityComparer
ByteArrayEqualityComparer
and remove redundant impl
shargon
reviewed
Nov 2, 2024
shargon
reviewed
Nov 3, 2024
shargon
previously approved these changes
Nov 7, 2024
shargon
added
Ready to Merge
and removed
Blocked
This issue can't be worked at the moment
Waiting for Review
labels
Nov 7, 2024
Jim8y
previously approved these changes
Nov 7, 2024
Wait for #3503 |
shargon
approved these changes
Nov 8, 2024
Jim8y
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A better and simpler impl for ByteArrayEqualityComparer:
SeqenceEqual
for better performance and simpler implementation;Perf test on 4KiB equal bytes:
Type of change
Checklist: