-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support file path to base64 in parse #3487
Conversation
I see. This is base64(base64(.nefFile)) |
Changed this PR to support only file path to base64 |
{ | ||
if (!File.Exists(path)) return null; | ||
return Convert.ToBase64String(File.ReadAllBytes(path)); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I don't think we need this command for CLI because it's always possible to cat file.txt | base64
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also possible but the command is a bit longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any use case for this
To be honest, I do not think it useful either. |
Close? |
there are some websites that require |
Co-authored-by: Shargon <[email protected]>
Description
An enhancement for #3482 (but also works alone). Hex string input had already been supported in the method
Base64Fixed
, and is not considered.Type of change
How Has This Been Tested?
parse C:\Users\some_file.nef_or_anything
Typically it prints quite a few screens of hex, base64 and instructions, if the input is a .nef path. It works when the input path includes spaces. The user can wrap the input path with or without double quotation marks
"
, whether the path includes spaces or not.Checklist: