Add UT Neo.Extensions #3467
Merged
Add UT Neo.Extensions #3467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Aug 23, 2024
| @@ -43,6 +43,11 @@ public static BigInteger Mod(this BigInteger x, BigInteger y) | |||
|
|
|||
| public static BigInteger ModInverse(this BigInteger a, BigInteger n) | |||
| { | |||
There was a problem hiding this comment.
It shouldn't, VM uses its own implementation of ModInverse for OpCode.MODPOW handling.
But this method is used for operations with ECPoint (division and addition), thus I'd check if native CryptoLib's contract operations are not affected.
|
i am adding more edge testes in this pr, please hold a while |
Jim8y
previously approved these changes
Aug 27, 2024
Jim8y
approved these changes
Aug 27, 2024
vncoelho
approved these changes
Aug 29, 2024
|
Good tests, @chenzhitong, they are important for BigInteger use cases |
shargon
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.