-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neo Store UT] Add leveldb thread UT and readme. #3427
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But leveldb
does support multi-threading and so does the interface
(IStore
). The classes that inherit IStore
are not thread safe. I said this at the begin when i started work here.
No, it does not. Did i do anything saying it does here? Aren't we are saying exactly the same thing? |
Then why you think your tests are failing than? Your testing the wrong thing, you need to be testing |
which test are failing, aren't they all passed? Will test snapshotcache later. |
Co-authored-by: Christopher Schuchardt <[email protected]>
Co-authored-by: Christopher Schuchardt <[email protected]>
one UT is faulted :S |
@Jim8y one test fail |
Description
Leveldb itself is not thread safe, thus having this pr to demonstrate how leveldb snapshot behaves under multi thread env.
Quote from leveldb document https://github.com/google/leveldb/blob/main/doc/index.md :
Fixes # (issue)
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: