Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use devcontainer to run some CI tests #3347

Closed
wants to merge 4 commits into from
Closed

Use devcontainer to run some CI tests #3347

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e8267ec
Update main.yml
vncoelho Jun 18, 2024
b7d132c
Update main.yml
vncoelho Jun 18, 2024
2c4a4c6
Revert "Fixed Props paths for `*.csproj` builds (#3320)"
vncoelho Jun 18, 2024
867999b
Update main.yml
vncoelho Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,19 @@ jobs:
${{ github.workspace }}/tests/Neo.Plugins.RpcServer.Tests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.Plugins.Storage.Tests/TestResults/coverage.info

DevContainer-LocalEnv:
timeout-minutes: 15
runs-on: ubuntu-latest
steps:
- name: Checkout (GitHub)
uses: actions/checkout@v4

- name: Build and run dev container task
uses: devcontainers/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use v0.3.1900000349?

Copy link
Member Author

@vncoelho vncoelho Jun 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that, but what should be the nomenclature there? all these numbers?

Copy link
Member

@cschuchardt88 cschuchardt88 Jun 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/devcontainers/ci/tree/chrmarti/federated-ids?tab=readme-ov-file#changelog

https://github.com/devcontainers/ci/blob/chrmarti/federated-ids/docs/github-action.md

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I have an image already. https://github.com/cschuchardt88/neo/pkgs/container/neo-cli

with:
# try with dotnet test - this is duplicated but at the end of the CI for now
runCmd: dotnet test

PublishPackage:
if: github.ref == 'refs/heads/master' && startsWith(github.repository, 'neo-project/')
needs: [Test]
Expand Down
Loading