install latest plugin when the modules are not released for the latest neo-cli #3229

Jim8y · 2024-05-13T03:54:34Z

Description

Cli will not able to install plugin if the modules are not yet released. So this pr will help the cli to install the latest plugin that can find on github.

Fixes # (issue)

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Test Configuration:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

…t neo-cli

cschuchardt88

Can you fix the warning.

shargon

Could you test it @superboyiii ? LGTM

src/Neo.CLI/CLI/MainService.Plugins.cs

cschuchardt88 · 2024-05-14T15:38:24Z

src/Neo.CLI/CLI/MainService.Plugins.cs

+            {
+                // If the corresponding version of the plugin is not found, get the latest version
+                jsonRelease = json.AsArray()
+                    .OrderByDescending(s => Version.Parse(s["tag_name"]!.GetValue<string>()?.TrimStart('v')))


Version.Parse will crash if it's null. or we have a tag_name that isn't valid format.

cschuchardt88 · 2024-05-14T15:39:12Z

We should wait for neo-module merge to this repo before we update this!

Jim8y · 2024-05-14T15:41:33Z

We should wait for neo-module merge to this repo before we update this!

This has nothing to do with modules. I am just dealing with something else.

cschuchardt88 · 2024-05-14T15:44:28Z

We should wait for neo-module merge to this repo before we update this!

This has nothing to do with modules. I am just dealing with something else.

Maybe we should download from nuget. Because we moving download URL.

cschuchardt88 · 2024-05-16T05:34:30Z

We should wait for neo-module merge to this repo before we update this!

This has nothing to do with modules. I am just dealing with something else.

@Jim8y
Yes it does, we won't be using that repo anymore. So URL will change. But I do see your point.

shargon · 2024-05-24T10:33:19Z

src/Neo.CLI/CLI/MainService.Plugins.cs

+                    if (latestVersion < pluginVersion)
+                    {
+                        // If the latest version is lower than the locally passed version, use https://github.com/neo-project/neo-modules/releases/latest/download to get the latest version
+                        var latestDownloadUrl = $"https://github.com/neo-project/neo-modules/releases/latest/download/{pluginName}.zip";


We need to change the url to neo now, also for DownloadUrl, could you do it @Jim8y ?

…gins * 'latest-plugins' of github.com:Jim8y/neo: (21 commits) fix: custom plugins won't shown by command `plugins` (neo-project#3269) COVERALL: Improve maintenance and readbility of some variables (neo-project#3248) Update nuget (neo-project#3262) [**Part-2**] Neo module/master fixes (neo-project#3244) Fix `dotnet pack` error (neo-project#3266) Fix and Update devcontainer.json to use Dockerfile (neo-project#3259) Add optimization to template (neo-project#3247) Optimize plugin's models (neo-project#3246) fix CancelTransaction !signers.Any() (neo-project#3263) COVERALL: fix broken by changing report from lcov to cobertura (neo-project#3252) fix TraverseIterator count (neo-project#3261) Native: include DeprecatedIn hardfork into usedHardforks (neo-project#3245) [**Part-1**] `neo-module/master` (neo-project#3232) Make `ApplicationEngine.LoadContext` protection level `public` (neo-project#3243) improve parse method in neo-cli (neo-project#3204) Fix neo-project#3239 (neo-project#3242) Neo.CLI: enable hardforks for NeoFS mainnet (neo-project#3240) v3.7.4 (neo-project#3237) fix hardfork issues (neo-project#3234) Update src/Neo.CLI/CLI/MainService.Plugins.cs ... # Conflicts: # src/Neo.CLI/CLI/MainService.Plugins.cs

cschuchardt88 · 2024-05-25T08:06:16Z

src/Neo.CLI/CLI/MainService.Plugins.cs

+                    .Where(s => s?["prerelease"]?.GetValue<bool>() == prerelease)
+                    .Select(s =>
+                    {
+                        var tagName = s["tag_name"]?.GetValue<string>();


Fix Dereference of a possibly null reference warning.

s?["tag_name"]?.GetValue<string>() i think s? was needed.

src/Neo.CLI/CLI/MainService.Plugins.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

src/Neo.CLI/CLI/MainService.Plugins.cs

Co-authored-by: Christopher Schuchardt <[email protected]>

Jim8y · 2024-05-27T23:42:52Z

@superboyiii will need you to release a plugin version at this repo to test.

cschuchardt88 · 2024-05-28T13:05:38Z

@superboyiii will need you to release a plugin version at this repo to test.

He can release on his own repo and change the URL.

superboyiii · 2024-05-29T08:29:49Z

I will check this

superboyiii · 2024-05-31T07:00:09Z

@Jim8y Just a little worried about if someone use v3.7.4 CLI to install v3.7.5 Plugins, they may not want to upgrade CLI if there're only hotfixes on plugins.... If we consider the title situation, we should consider this situation as well. Or maybe we should release both cli and plugins everytime, it can also solve these.

superboyiii · 2024-05-31T07:13:09Z

src/Neo.CLI/CLI/MainService.Plugins.cs

+                    if (latestVersion < pluginVersion)
+                    {
+                        var latestDownloadUrl = $"https://github.com/neo-project/neo/releases/download/v{latestVersion}/{pluginName}.zip";
+                        ConsoleHelper.Info($"Could not find the corresponding version, installing the latest: v{latestVersion}");
+                        return await httpClient.GetStreamAsync(latestDownloadUrl);
+                    }


We need take care of (latestVersion > pluginVersion), why not always pick the latestVersion?

cschuchardt88 · 2024-06-27T07:27:02Z

I think with the release of 3.7.5 this should be good now. If no more issues in PR.

@Jim8y Resolve conflicts

src/Neo.CLI/CLI/MainService.Plugins.cs

shargon · 2024-08-12T06:00:45Z

src/Neo.CLI/CLI/MainService.Plugins.cs

+
+                if (jsonRelease != null)
+                {
+                    var latestVersion = Version.Parse(jsonRelease["tag_name"]!.GetValue<string>()[1..]);


Why this 1? Start with v?

src/Neo.CLI/CLI/MainService.Plugins.cs

AnnaShaleva · 2024-08-23T17:53:15Z

src/Neo.CLI/CLI/MainService.Plugins.cs

+
+                if (jsonRelease != null)
+                {
+                    var latestVersion = Version.Parse(jsonRelease["tag_name"]!.GetValue<string>()[1..]);


Use Version.TryParse instead of Version.Parse?

Version.TryParse is good

Co-authored-by: Anna Shaleva <[email protected]>

install latest plugin when the modules are not released for the lates…

9f3d04e

…t neo-cli

Jim8y requested review from NGDAdmin and cschuchardt88 May 13, 2024 03:54

Jim8y added the waiting for review label May 13, 2024

cschuchardt88 requested changes May 13, 2024

View reviewed changes

Merge branch 'master' into latest-plugins

dc8d25c

shargon previously approved these changes May 13, 2024

View reviewed changes

cschuchardt88 requested changes May 13, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.Plugins.cs Outdated Show resolved Hide resolved

superboyiii reviewed May 14, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.Plugins.cs Show resolved Hide resolved

fix null checking

5d4b441

shargon reviewed May 14, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.Plugins.cs Outdated Show resolved Hide resolved

shargon dismissed their stale review via 0e97b46 May 14, 2024 08:22

Update src/Neo.CLI/CLI/MainService.Plugins.cs

0e97b46

shargon previously approved these changes May 14, 2024

View reviewed changes

cschuchardt88 requested changes May 14, 2024

View reviewed changes

Merge branch 'master' into latest-plugins

9976555

shargon reviewed May 24, 2024

View reviewed changes

Jim8y dismissed shargon’s stale review via 4a96d1e May 25, 2024 06:24

url

2ad35ce

cschuchardt88 requested changes May 25, 2024

View reviewed changes

Update src/Neo.CLI/CLI/MainService.Plugins.cs

0d5ca4b

Co-authored-by: Christopher Schuchardt <[email protected]>

cschuchardt88 requested changes May 26, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.Plugins.cs Outdated Show resolved Hide resolved

Update src/Neo.CLI/CLI/MainService.Plugins.cs

06e8fa9

Co-authored-by: Christopher Schuchardt <[email protected]>

cschuchardt88 previously approved these changes May 26, 2024

View reviewed changes

Merge branch 'master' into latest-plugins

62592b1

Jim8y requested a review from a team May 27, 2024 23:42

shargon added 2 commits May 28, 2024 00:40

Merge branch 'master' into latest-plugins

30457c7

Merge branch 'master' into latest-plugins

a7ec0d0

Merge branch 'master' into latest-plugins

e685843

superboyiii reviewed May 31, 2024

View reviewed changes

Jim8y added the need update label Jun 1, 2024

Merge branch 'master' into latest-plugins

eb64efd

Merge branch 'master' into latest-plugins

63fa805

Jim8y dismissed cschuchardt88’s stale review via 63fa805 August 12, 2024 02:51

shargon reviewed Aug 12, 2024

View reviewed changes

src/Neo.CLI/CLI/MainService.Plugins.cs Outdated Show resolved Hide resolved

Update src/Neo.CLI/CLI/MainService.Plugins.cs

a9a41e2

shargon previously approved these changes Aug 12, 2024

View reviewed changes

Merge branch 'master' into latest-plugins

37a41d5

cschuchardt88 previously approved these changes Aug 14, 2024

View reviewed changes

Merge branch 'master' into latest-plugins

59d3217

AnnaShaleva reviewed Aug 23, 2024

View reviewed changes

Update src/Neo.CLI/CLI/MainService.Plugins.cs

5b1e2fd

Co-authored-by: Anna Shaleva <[email protected]>

shargon dismissed stale reviews from cschuchardt88 and themself via 5b1e2fd August 23, 2024 18:02

Merge branch 'master' into latest-plugins

b7835e0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

install latest plugin when the modules are not released for the latest neo-cli #3229

install latest plugin when the modules are not released for the latest neo-cli #3229

Jim8y commented May 13, 2024

cschuchardt88 left a comment

shargon left a comment

cschuchardt88 May 14, 2024

cschuchardt88 commented May 14, 2024 •

edited

Loading

Jim8y commented May 14, 2024

cschuchardt88 commented May 14, 2024

cschuchardt88 commented May 16, 2024

shargon May 24, 2024

cschuchardt88 May 25, 2024 •

edited

Loading

Jim8y commented May 27, 2024

cschuchardt88 commented May 28, 2024

superboyiii commented May 29, 2024

superboyiii commented May 31, 2024

superboyiii May 31, 2024 •

edited

Loading

cschuchardt88 commented Jun 27, 2024

shargon Aug 12, 2024

AnnaShaleva Aug 23, 2024

cschuchardt88 Aug 24, 2024 •

edited

Loading

install latest plugin when the modules are not released for the latest neo-cli #3229

Are you sure you want to change the base?

install latest plugin when the modules are not released for the latest neo-cli #3229

Conversation

Jim8y commented May 13, 2024

Description

Type of change

Checklist:

cschuchardt88 left a comment

Choose a reason for hiding this comment

shargon left a comment

Choose a reason for hiding this comment

cschuchardt88 May 14, 2024

Choose a reason for hiding this comment

cschuchardt88 commented May 14, 2024 • edited Loading

Jim8y commented May 14, 2024

cschuchardt88 commented May 14, 2024

cschuchardt88 commented May 16, 2024

shargon May 24, 2024

Choose a reason for hiding this comment

cschuchardt88 May 25, 2024 • edited Loading

Choose a reason for hiding this comment

Jim8y commented May 27, 2024

cschuchardt88 commented May 28, 2024

superboyiii commented May 29, 2024

superboyiii commented May 31, 2024

superboyiii May 31, 2024 • edited Loading

Choose a reason for hiding this comment

cschuchardt88 commented Jun 27, 2024

shargon Aug 12, 2024

Choose a reason for hiding this comment

AnnaShaleva Aug 23, 2024

Choose a reason for hiding this comment

cschuchardt88 Aug 24, 2024 • edited Loading

Choose a reason for hiding this comment

cschuchardt88 commented May 14, 2024 •

edited

Loading

cschuchardt88 May 25, 2024 •

edited

Loading

superboyiii May 31, 2024 •

edited

Loading

cschuchardt88 Aug 24, 2024 •

edited

Loading