Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.7.1 #3224

Merged
merged 6 commits into from
May 10, 2024
Merged

v3.7.1 #3224

merged 6 commits into from
May 10, 2024

Conversation

superboyiii
Copy link
Member

@superboyiii superboyiii commented May 10, 2024

Description

Wrong usage of TargetFramework which prevents CLI from dotnet publish.
See: https://learn.microsoft.com/en-us/dotnet/standard/frameworks#how-to-specify-a-target-framework

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Test A
  • Test B

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Jim8y
Jim8y previously approved these changes May 10, 2024
@superboyiii
Copy link
Member Author

@cschuchardt88 @shargon Need help for workflow

@Jim8y
Copy link
Contributor

Jim8y commented May 10, 2024

coverage.net8.0.info -> coverage.json maybe

Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: Couldn't find specified file: /home/runner/work/neo/neo/TestResults/coverage/coverage.net8.0.info

@NGDAdmin NGDAdmin merged commit 1d95792 into neo-project:master May 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants