Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLS coverage result has a different name than the rest #3162

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

vncoelho
Copy link
Member

close #3160

@vncoelho
Copy link
Member Author

vncoelho commented Feb 23, 2024

locally it fixed

with first test dotnet test ./tests/Neo.Cryptography.BLS12_381.Tests we have:

#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Module                     | Line   | Branch | Method |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Neo.Cryptography.BLS12_381 | 83.22% | 55%    | 69.2%  |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Neo.ConsoleService         | 15.66% | 13.04% | 19.4%  |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 
#21 19.95 +---------+--------+--------+--------+
#21 19.95 |         | Line   | Branch | Method |
#21 19.95 +---------+--------+--------+--------+
#21 19.95 | Total   | 68.29% | 30.67% | 60.47% |
#21 19.95 +---------+--------+--------+--------+
#21 19.95 | Average | 49.44% | 34.01% | 44.3%  |
#21 19.95 +---------+--------+--------+--------+

then after dotnet test ./tests/Neo.UnitTests it is now increasing instead of decreasing

#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Module                     | Line   | Branch | Method |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Cryptography.BLS12_381 | 87.99% | 63%    | 73.96% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.IO                     | 75.36% | 83.82% | 75%    |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.VM                     | 33.95% | 25.9%  | 41.88% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo                        | 78.88% | 65.32% | 81.52% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Extensions             | 78.57% | 0%     | 80%    |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Json                   | 36.23% | 13.66% | 40.46% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.ConsoleService         | 15.66% | 13.04% | 19.4%  |
#23 26.94 +----------------------------+--------+--------+--------+

@vncoelho
Copy link
Member Author

coverage/coveralls — Coverage increased (+1.9%) to 75.829%

@vncoelho vncoelho changed the title BLS coverage package has a different name than the rest BLS coverage result has a different name than the rest Feb 23, 2024
Jim8y
Jim8y previously approved these changes Feb 23, 2024
@Jim8y
Copy link
Contributor

Jim8y commented Feb 23, 2024

LGTM

@Jim8y
Copy link
Contributor

Jim8y commented Feb 23, 2024

@shargon up to you.

.github/workflows/main.yml Outdated Show resolved Hide resolved
@shargon
Copy link
Member

shargon commented Feb 23, 2024

There is something wrong, we should do it or after the first, or in all of them, we need to check

@vncoelho
Copy link
Member Author

There is something wrong, we should do it or after the first, or in all of them, we need to check

You can do it first and avoid the mv

@vncoelho
Copy link
Member Author

like the last commit, take a look @shargon

let's see if the result will be the same

.github/workflows/main.yml Outdated Show resolved Hide resolved
@shargon shargon requested a review from Jim8y February 23, 2024 14:11
@vncoelho
Copy link
Member Author

it worked the same way

@shargon shargon merged commit 9373756 into master Feb 23, 2024
7 checks passed
@shargon shargon deleted the vncoelho-patch-1 branch February 23, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage for BLS still looks like to be wrong
3 participants