-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLS coverage result has a different name than the rest #3162
Conversation
close #3160
locally it fixed with first test #21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Module | Line | Branch | Method |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Neo.Cryptography.BLS12_381 | 83.22% | 55% | 69.2% |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95 | Neo.ConsoleService | 15.66% | 13.04% | 19.4% |
#21 19.95 +----------------------------+--------+--------+--------+
#21 19.95
#21 19.95 +---------+--------+--------+--------+
#21 19.95 | | Line | Branch | Method |
#21 19.95 +---------+--------+--------+--------+
#21 19.95 | Total | 68.29% | 30.67% | 60.47% |
#21 19.95 +---------+--------+--------+--------+
#21 19.95 | Average | 49.44% | 34.01% | 44.3% |
#21 19.95 +---------+--------+--------+--------+ then after #23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Module | Line | Branch | Method |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Cryptography.BLS12_381 | 87.99% | 63% | 73.96% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.IO | 75.36% | 83.82% | 75% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.VM | 33.95% | 25.9% | 41.88% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo | 78.88% | 65.32% | 81.52% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Extensions | 78.57% | 0% | 80% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.Json | 36.23% | 13.66% | 40.46% |
#23 26.94 +----------------------------+--------+--------+--------+
#23 26.94 | Neo.ConsoleService | 15.66% | 13.04% | 19.4% |
#23 26.94 +----------------------------+--------+--------+--------+ |
|
LGTM |
@shargon up to you. |
There is something wrong, we should do it or after the first, or in all of them, we need to check |
You can do it first and avoid the mv |
like the last commit, take a look @shargon let's see if the result will be the same |
Co-authored-by: Shargon <[email protected]>
it worked the same way |
close #3160