Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core Fix] add loadstore back #3141

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Feb 15, 2024

Description

This pr focus on adding LoadStore back as it was removed by silly me. Plugins still need it, and plugins can not access the store field of neoststem as it is private, therefore this is not marked as obsolete.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y added waiting for review blocker Issues that are blocking other issues. Check issues details to see what it is blocking. labels Feb 15, 2024
@Jim8y Jim8y self-assigned this Feb 15, 2024
@Jim8y
Copy link
Contributor Author

Jim8y commented Feb 15, 2024

This pr blocks neo-project/neo-modules#873 , will update it once this is merged.

Copy link
Contributor

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice to mention #3124 where this regression came from.

@shargon shargon merged commit fd3d68d into neo-project:master Feb 15, 2024
1 of 2 checks passed
@Jim8y Jim8y deleted the restore-loadstore branch February 16, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Issues that are blocking other issues. Check issues details to see what it is blocking. waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants