some nodes on testnet stopped syncing maybe caused by some modules #3296

dusmart · 2024-06-06T14:13:02Z

Describe the bug

When I'm developing new contracts and wants to see the GAS consumed on testnet. Some nodes are stopped.

2 explorers stopped syncing, only onegate lives now.

To Reproduce

send a tx like this https://testmagnet.explorer.onegate.space/transactionInfo/0xd73b99b222151ddab5891023a705adc450c5779ab25bb225a7b8f9871ffdd16a.

Expected behavior

Normal end.

Screenshots

Platform:

Version 3.7.4
Node Type C#

(Optional) Additional context

The contracts' code before stopped syncing is in details.
Calling the main with parameter 100 will give you a 3.2MB result by RpcServer plugin.
I suspect that it's caused by some plugins based on previous experience all RPC nodes on testnet stopped syncing maybe caused by some modules #2666.

using System;
using System.ComponentModel;
using Neo.SmartContract.Framework;
using Neo.SmartContract.Framework.Attributes;
using Neo.SmartContract.Framework.Services;

namespace bigevent
{
    [DisplayName("bigevent")]
    [ManifestExtra("Author", "NEO")]
    [ManifestExtra("Email", "[email protected]")]
    [ManifestExtra("Description", "This is a bigevent")]
    public class bigevent : SmartContract
    {
        public static ByteString[] ns = new ByteString[]{"", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", "", ""};

        public static event SyncedEvent Synced;
        public delegate void SyncedEvent(ByteString[] ns);

        public static void Update(ByteString nefFile, string manifest) {
            Neo.SmartContract.Framework.Native.ContractManagement.Update(nefFile, manifest, null);
        }

        public static Notification[] Main(int i)
        {
            while (i > 0) {
                Synced(ns);
                i--;
            }
            return Runtime.GetNotifications(Runtime.ExecutingScriptHash);
        }
    }
}

The text was updated successfully, but these errors were encountered:

lingyido · 2024-06-06T16:41:01Z

FYI. My C# testnet node 3.7.4 with only leveldb plugin installed works and syncs well.

lingyido · 2024-06-06T16:53:56Z

LOL. You're doing bad experiments. AoAaBgABLAESwB8MBG1haW4MFFMo9Cc1/EJCiUOG1Ow0/ZfStZoXQWJ9W1I= script cost me 5 minutes and 16_68745493 datoshi on my PC.

dusmart · 2024-06-06T17:41:52Z

I suggest that some seed nodes and explorer nodes on testnet to uninstall unnecessary modules.

IIRC, testnet's GAS fee factor is 1/3 compared to mainnet now, which means that the script could cost only ~50 GAS on mainnet. It's a failed experiments. @lingyido

lock9 · 2024-06-06T17:56:31Z

@dusmart The fees are different, but I'm not sure if they should:

neoxp policy get -r https://testnet1.neo.coz.io
             GasPerBlock: 500000000 (5 GAS)
    MinimumDeploymentFee: 1000000000 (10 GAS)
CandidateRegistrationFee: 100000000000 (1000 GAS)
        OracleRequestFee: 10000000 (0.1 GAS)
       NetworkFeePerByte: 20 (0.0000002 GAS)
        StorageFeeFactor: 1000
      ExecutionFeeFactor: 1

neoxp policy get -r https://mainnet1.neo.coz.io
             GasPerBlock: 500000000 (5 GAS)
    MinimumDeploymentFee: 1000000000 (10 GAS)
CandidateRegistrationFee: 100000000000 (1000 GAS)
        OracleRequestFee: 10000000 (0.1 GAS)
       NetworkFeePerByte: 100 (0.000001 GAS)
        StorageFeeFactor: 10000
      ExecutionFeeFactor: 3

Shouldn't both networks have the same parameters? @roman-khimov I remember you saying something about this but I can't find where.

roman-khimov · 2024-06-06T20:39:11Z

I suggest that some seed nodes and explorer nodes on testnet to uninstall unnecessary modules.

Likely it's not even possible for explorer nodes (they need application logs and RPC). And I always expect seed nodes to have almost all plugins.

AoAaBgABLAESwB8MBG1haW4MFFMo9Cc1/EJCiUOG1Ow0/ZfStZoXQWJ9W1I= script cost me 5 minutes

$ time curl -sd '{ "jsonrpc": "2.0", "id": 5, "method": "invokescript", "params": ["AoAaBgABLAESwB8MBG1haW4MFFMo9Cc1/EJCiUOG1Ow0/ZfStZoXQWJ9W1I="] }' https://rpc.t5.n3.nspcc.ru:20331 >/dev/null

real    0m2,814s
user    0m0,058s
sys     0m0,052s

Shouldn't both networks have the same parameters?

I guess testnet was updated with newer proposed parameters some time ago.

dusmart · 2024-06-07T01:23:43Z

Likely it's not even possible for explorer nodes (they need application logs and RPC).

Then they're the necessary part. I mean to uninstall those unnecessary one.

And I always expect seed nodes to have almost all plugins.

Then one buggy plugin could cause such a damage. 2/3 of the explorer stopped syncing now and a lot of wallet with default rpc settings stopped now.

I suppose that maybe letting 1/5 install 1/5 part unnecessary plugins and other 1/5 install others is better.

$ time curl -sd '{ "jsonrpc": "2.0", "id": 5, "method": "invokescript", "params": ["AoAaBgABLAESwB8MBG1haW4MFFMo9Cc1/EJCiUOG1Ow0/ZfStZoXQWJ9W1I="] }' https://rpc.t5.n3.nspcc.ru:20331 >/dev/null

Your node is so fast. Have you compare that if the result is same between C# and golang? It seems that two type of nodes cost different amount of GAS.

superboyiii · 2024-06-07T02:13:15Z

@dusmart The fees are different, but I'm not sure if they should:

neoxp policy get -r https://testnet1.neo.coz.io
             GasPerBlock: 500000000 (5 GAS)
    MinimumDeploymentFee: 1000000000 (10 GAS)
CandidateRegistrationFee: 100000000000 (1000 GAS)
        OracleRequestFee: 10000000 (0.1 GAS)
       NetworkFeePerByte: 20 (0.0000002 GAS)
        StorageFeeFactor: 1000
      ExecutionFeeFactor: 1

neoxp policy get -r https://mainnet1.neo.coz.io
             GasPerBlock: 500000000 (5 GAS)
    MinimumDeploymentFee: 1000000000 (10 GAS)
CandidateRegistrationFee: 100000000000 (1000 GAS)
        OracleRequestFee: 10000000 (0.1 GAS)
       NetworkFeePerByte: 100 (0.000001 GAS)
        StorageFeeFactor: 10000
      ExecutionFeeFactor: 3

Shouldn't both networks have the same parameters? @roman-khimov I remember you saying something about this but I can't find where.

It's a new proposal made by council on testnet to reduce fees. We're testing on it.

dusmart · 2024-06-07T05:23:19Z

LOL. You're doing bad experiments. AoAaBgABLAESwB8MBG1haW4MFFMo9Cc1/EJCiUOG1Ow0/ZfStZoXQWJ9W1I= script cost me 5 minutes and 16_68745493 datoshi on my PC.

@lingyido here comes the bad one #3300

roman-khimov · 2024-06-07T07:59:12Z

Then one buggy plugin could cause such a damage

Sure. But who needs a node without plugins? CNs? There are a few of those. Everyone else needs at least RPC and application logs, otherwise it's a useless node that can't be used for dApp development. So if you have a problem in any of those plugins it's exactly that for users --- "broken node, please fix it". No one cares if it's a plugin, it's an essential thing for most users.

dusmart · 2024-06-07T08:25:04Z

But who needs a node without plugins?

We have multiple seed nodes. Each can have a set of unnecessary plugins. Users can use different functions from different nodes. At least, let some of the seed nodes live when an unimportant plugin breaks.

dusmart · 2024-06-07T08:28:41Z

"broken node, please fix it". No one cares if it's a plugin, it's an essential thing for most users.

Yeap. When some plugins breaks, if we could let the wallets and explorers works as usual, it would be better. We surely need to fix any official plugins. But it's not necessary to break so many tools. I have to express my appreciation to onegate here. They didn't stuck at all at this time.

I'm not sure how onegate managed to survive when the ApplicationLog plugins break. But it shows that ApplicationLog is not as important as the core node itself.

Jim8y · 2024-06-07T08:45:28Z

"broken node, please fix it". No one cares if it's a plugin, it's an essential thing for most users.

Yeap. When some plugins breaks, if we could let the wallets and explorers works as usual, it would be better. We surely need to fix any official plugins. But it's not necessary to break so many tools. I have to express my appreciation to onegate here. They didn't stuck at all at this time.

I'm not sure how onegate managed to survive when the ApplicationLog plugins break. But it shows that ApplicationLog is not as important as the core node itself.

i am working to run each plugin in seperate process.

lingyido · 2024-06-07T10:06:25Z

This is a reason why I only install leveldb and my own plugins. And my node worked well, by the way. You can try your own node like me.

Jim8y · 2024-06-08T16:53:43Z

"broken node, please fix it". No one cares if it's a plugin, it's an essential thing for most users.

Yeap. When some plugins breaks, if we could let the wallets and explorers works as usual, it would be better. We surely need to fix any official plugins. But it's not necessary to break so many tools. I have to express my appreciation to onegate here. They didn't stuck at all at this time.
I'm not sure how onegate managed to survive when the ApplicationLog plugins break. But it shows that ApplicationLog is not as important as the core node itself.

i am working to run each plugin in seperate process.

Easier and efficient solution now available here #3309. Seperate process will take longer.

lingyido mentioned this issue Jun 6, 2024

NEO faucet isn't working #3298

Closed

dusmart mentioned this issue Jun 7, 2024

C#-v3.7.4 and NEOGO-0.106.1 calling result mismatch nspcc-dev/neo-go#3482

Closed

Jim8y mentioned this issue Jun 7, 2024

[Neo Plugin Bug]fix 3296 #3299

Merged

14 tasks

Jim8y linked a pull request Jun 7, 2024 that will close this issue

[Neo Plugin Bug]fix 3296 #3299

Merged

14 tasks

Jim8y mentioned this issue Jun 8, 2024

[Neo Core] Part 1. Isolate Plugins Exceptions from the Node. #3309

Merged

14 tasks

NGDAdmin closed this as completed in #3299 Jun 11, 2024

dusmart mentioned this issue Jun 11, 2024

make it possible to build large objects lazynode/Tanya#33

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

some nodes on testnet stopped syncing maybe caused by some modules #3296

some nodes on testnet stopped syncing maybe caused by some modules #3296

dusmart commented Jun 6, 2024 •

edited

Loading

lingyido commented Jun 6, 2024

lingyido commented Jun 6, 2024

dusmart commented Jun 6, 2024

lock9 commented Jun 6, 2024

roman-khimov commented Jun 6, 2024

dusmart commented Jun 7, 2024 •

edited

Loading

superboyiii commented Jun 7, 2024

dusmart commented Jun 7, 2024

roman-khimov commented Jun 7, 2024

dusmart commented Jun 7, 2024 •

edited

Loading

dusmart commented Jun 7, 2024 •

edited

Loading

Jim8y commented Jun 7, 2024

lingyido commented Jun 7, 2024

Jim8y commented Jun 8, 2024

some nodes on testnet stopped syncing maybe caused by some modules #3296

some nodes on testnet stopped syncing maybe caused by some modules #3296

Comments

dusmart commented Jun 6, 2024 • edited Loading

lingyido commented Jun 6, 2024

lingyido commented Jun 6, 2024

dusmart commented Jun 6, 2024

lock9 commented Jun 6, 2024

roman-khimov commented Jun 6, 2024

dusmart commented Jun 7, 2024 • edited Loading

superboyiii commented Jun 7, 2024

dusmart commented Jun 7, 2024

roman-khimov commented Jun 7, 2024

dusmart commented Jun 7, 2024 • edited Loading

dusmart commented Jun 7, 2024 • edited Loading

Jim8y commented Jun 7, 2024

lingyido commented Jun 7, 2024

Jim8y commented Jun 8, 2024

dusmart commented Jun 6, 2024 •

edited

Loading

dusmart commented Jun 7, 2024 •

edited

Loading

dusmart commented Jun 7, 2024 •

edited

Loading

dusmart commented Jun 7, 2024 •

edited

Loading