Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C#-v3.7.4 and NEOGO-0.106.1 calling result mismatch #3482

Closed
dusmart opened this issue Jun 7, 2024 · 3 comments · Fixed by #3485
Closed

C#-v3.7.4 and NEOGO-0.106.1 calling result mismatch #3482

dusmart opened this issue Jun 7, 2024 · 3 comments · Fixed by #3485
Labels
bug Something isn't working I4 No visible changes S4 Routine U2 Seriously planned
Milestone

Comments

@dusmart
Copy link

dusmart commented Jun 7, 2024

Between testnet C# v3.7.4 and golang NEO-GO:0.106.1. The calling results of AoAaBgABLAESwB8MBG1haW4MFFMo9Cc1/EJCiUOG1Ow0/ZfStZoXQWJ9W1I= differ.

Current Behavior

FAULT

Expected Behavior

HALT as what C# did

Possible Solution

I have no idea.

Steps to Reproduce

curl -sd '{ "jsonrpc": "2.0", "id": 5, "method": "invokescript", "params": ["AoAaBgABLAESwB8MBG1haW4MFFMo9Cc1/EJCiUOG1Ow0/ZfStZoXQWJ9W1I="] }' https://rpc.t5.n3.nspcc.ru:20331/ > /tmp/result_neogo.json

Context

neo-project/neo#3296

Your Environment

  • C# v3.7.4
  • golang NEO-GO:0.106.1
@dusmart dusmart added bug Something isn't working U2 Seriously planned labels Jun 7, 2024
@dusmart
Copy link
Author

dusmart commented Jun 7, 2024

As public accessible testnet C# nodes are not available for now. You may have to run you own local nodes. From the comparison of neogo's gas_consumed and c#'s, I guess that neogo is more strict than C#.

I'm not sure which one should be changed. As C# is now the mainstream on mainnet, I guess that we'd better adapt neogo to C#'s behavior.

@dusmart dusmart changed the title testnet calling result mismatch C#-v3.7.4 and NEOGO-0.106.1 calling result mismatch Jun 7, 2024
@dusmart
Copy link
Author

dusmart commented Jun 7, 2024

neo-project/neo#3300

Maybe it should be fixed by C#.

@roman-khimov roman-khimov added S4 Routine I4 No visible changes labels Jun 7, 2024
@roman-khimov
Copy link
Member

We'll check, but at instruction 177 (SYSCALL): stack is too big / json error: too big: size is somewhat inspiring in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working I4 No visible changes S4 Routine U2 Seriously planned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants