optimize the code to apply Hecate suggestion

neo-project · Jun 7, 2024 · dc0b574 · dc0b574
1 parent 1378d24
commit dc0b574
Showing 1 changed file with 5 additions and 12 deletions.
diff --git a/src/Plugins/ApplicationLogs/Store/LogStorageStore.cs b/src/Plugins/ApplicationLogs/Store/LogStorageStore.cs
@@ -160,20 +160,13 @@ public Guid PutStackItemState(StackItem stackItem)
             {
                 _snapshot.Put(key, BinarySerializer.Serialize(stackItem, ExecutionEngineLimits.Default with { MaxItemSize = (uint)Settings.Default.MaxStackSize }));
             }
-            catch (NotSupportedException ex) // Ref. https://github.com/neo-project/neo/issues/3296
-            {
-                var message = ex.Message.Length > 1024 ? string.Concat(ex.Message.AsSpan(0, 1021), "...") : ex.Message;
-                _snapshot.Put(key, Encoding.UTF8.GetBytes("Not Supported Exception: " + message));
-            }
-            catch (FormatException ex)
-            {
-                var message = ex.Message.Length > 1024 ? string.Concat(ex.Message.AsSpan(0, 1021), "...") : ex.Message;
-                _snapshot.Put(key, Encoding.UTF8.GetBytes("Format Exception: " + message));
-            }
             catch (Exception ex)
             {
-                var message = ex.Message.Length > 1024 ? string.Concat(ex.Message.AsSpan(0, 1021), "...") : ex.Message;
-                _snapshot.Put(key, Encoding.UTF8.GetBytes("Exception: " + message));
+                var detailedException = ex.Message;
+                if (detailedException.Length > 1024)
+                    detailedException = string.Concat(detailedException.AsSpan(0, 1021), "...");
+                ByteString exceptionRecord = new(Encoding.UTF8.GetBytes(detailedException));
+                _snapshot.Put(key, BinarySerializer.Serialize(exceptionRecord, ExecutionEngineLimits.Default with { MaxItemSize = (uint)Settings.Default.MaxStackSize }));
             }
             return id;
         }