Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/export import tx final application state #90

Closed
wants to merge 2 commits into from
Closed

Feat/export import tx final application state #90

wants to merge 2 commits into from

Conversation

vncoelho
Copy link
Member

Deals with neo-project/neo#712 during export and import only.

Under development, this is the initial draft for export, not yet fully tested.

@vncoelho vncoelho requested review from erikzhang and shargon April 29, 2019 13:14
@vncoelho vncoelho mentioned this pull request Apr 29, 2019
Closed
vncoelho
vncoelho commented Apr 29, 2019
View reviewed changes
ImportBlocks/ImportBlocks.cs

Console.Write($"Result is {txState["result"]}\n");
if (!txState["result"])
if ((int)txState["code"].AsNumber() == -100 || (int)txState["code"].AsNumber() == -32602 || (int)txState["code"].AsNumber() == -32600)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikzhang, @shargon, it would be nice to change this line for any kind of error.

@vncoelho
Copy link
Member Author

vncoelho commented Apr 30, 2019 •
edited
Loading

@erikzhang, what solution do you propose?
The idea is to simple export the Transaction state (halt or fault) and verify it during import, ensuring that you are processing the transaction accordingly.

@erikzhang
Copy link
Member

My solution is to manually copy the ApplicationLogs directory, and then the ImportBlocks plugin directly reads the json files.

@vncoelho
Copy link
Member Author

We thought about that, @erikzhang, the current Application Logs folder for Mainnet at height 3687369 is 3.9G.
What do you think, @igormcoelho?

That would be the easiest way without making changes.
Furthermore, with the MPT this might be unnecessary, right?

@vncoelho
Copy link
Member Author

I think there is not reason to push this for 2.x anymore.

In addition, for 3.0 we gonna have better solutions.

@vncoelho vncoelho closed this May 30, 2019
@vncoelho vncoelho deleted the feat/exportImportAppLog branch May 30, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzhang erikzhang Awaiting requested review from erikzhang

@shargon shargon Awaiting requested review from shargon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vncoelho @erikzhang